Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/dashboard: remove MallocNanoZone=0 from macOS 12 builder configuration #49940

Closed
dmitshur opened this issue Dec 3, 2021 · 3 comments
Closed

x/build/dashboard: remove MallocNanoZone=0 from macOS 12 builder configuration #49940

dmitshur opened this issue Dec 3, 2021 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Dec 3, 2021

The macOS 12 builder environments had MallocNanoZone=0 added to work around #49138. This is the tracking issue to remove that workaround once it is no longer needed.

@cherrymui CL 367916 has recently closed #49138; do you know if now a good time to stop using MallocNanoZone=0?
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 3, 2021
@gopherbot gopherbot added this to the Unreleased milestone Dec 3, 2021
@cherrymui
Copy link
Member

I think it should be okay to remove the environment variable for tip (and Go 1.18). But we still need it for 1.17. I'll work on a workaround for 1.17 then we can remove it.

@heschi heschi added this to Planned in Go Release Team Dec 7, 2021
@dmitshur
Copy link
Contributor Author

dmitshur commented Dec 7, 2021

Thanks Cherry. We'll wait for the 1.17 workaround to land. I think it can be removed from builder configuration when 1.18 is released and 1.16 stops being supported. So waiting on that.

@dmitshur dmitshur modified the milestones: Unreleased, Go1.19 Dec 7, 2021
@dmitshur dmitshur added the early-in-cycle A change that should be done early in the 3 month dev cycle. label Dec 7, 2021
@gopherbot
Copy link

Change https://golang.org/cl/374334 mentions this issue: dashboard: remove MallocNanoZone environment variable workaround

@dmitshur dmitshur moved this from Planned to In Progress in Go Release Team Dec 24, 2021
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 24, 2021
@dmitshur dmitshur modified the milestones: Go1.19, Unreleased Dec 24, 2021
@dmitshur dmitshur removed the early-in-cycle A change that should be done early in the 3 month dev cycle. label Dec 24, 2021
Go Release Team automation moved this from In Progress to Done Dec 28, 2021
@golang golang locked and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @cherrymui