Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: "The Laws of Reflection" blog post needs a section on generics #49939

Closed
griesemer opened this issue Dec 3, 2021 · 2 comments
Closed

x/website: "The Laws of Reflection" blog post needs a section on generics #49939

griesemer opened this issue Dec 3, 2021 · 2 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.18

Comments

@griesemer
Copy link
Contributor

The blog post The Laws of Reflection, while old, is still a commonly used in-depth resource for the reflect package. There needs to be a preamble explaining how the reflect package is affected by generics (it isn't).

cc: @ianlancetaylor
cc: @robpike
@griesemer griesemer added Documentation Issues describing a change to documentation. release-blocker okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Dec 3, 2021
@griesemer griesemer added this to the Go1.18 milestone Dec 3, 2021
@robpike
Copy link
Contributor

robpike commented Dec 3, 2021

I would say rather than a preamble, it just needs a clarification in a couple of places. It also needs a tweak because Println etc. now handle reflect.Type more nicely, which invalidates a tiny bit of explanation.

@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 3, 2021
@robpike robpike self-assigned this Dec 3, 2021
@cherrymui cherrymui removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Dec 14, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/380276 mentions this issue: blog: update laws of reflection article

@rsc rsc unassigned robpike Jun 23, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
blog: update laws of reflection article
f1cf797 
There were a couple of minor things that were slightly wrong due to
changes in the libraries, and the addition of generics makes the meaning
of an interface worth clarifying.

Add an introductory paragraph about generics, and adjust a few
sentences.

No substantive change.

Fixes golang/go#49939

Change-Id: I67fbd28f1a9876158006202bf03ea693265c5cd5
Reviewed-on: https://go-review.googlesource.com/c/website/+/380276
Reviewed-by: DO NOT USE <iant@google.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Michael Knyszek <mknyszek@google.com>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
5 participants
@mknyszek @robpike @griesemer @gopherbot @cherrymui