Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: Effective Go needs to have a preamble re: generics #49937

Closed
griesemer opened this issue Dec 3, 2021 · 6 comments
Closed

x/website: Effective Go needs to have a preamble re: generics #49937

griesemer opened this issue Dec 3, 2021 · 6 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.18

Comments

@griesemer
Copy link
Contributor

Effective Go needs to be updated with a preamble/disclaimer as it was not written with generics in mind.

cc: @robpike
@griesemer griesemer added Documentation release-blocker okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Dec 3, 2021
@griesemer griesemer added this to the Go1.18 milestone Dec 3, 2021
@robpike
Copy link
Contributor

robpike commented Dec 3, 2021

It should also mention that is old and dated (and frozen) and has little about libraries and some other emergent best practices. A preamble is probably the right fit here.

@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 3, 2021
@robpike robpike self-assigned this Dec 3, 2021
@robpike
Copy link
Contributor

robpike commented Dec 3, 2021

Duplicate of #48274

@robpike robpike marked this as a duplicate of #48274 Dec 3, 2021
@susugagalala
Copy link

The book "The Go Programming Language" needs to be updated.

@cherrymui cherrymui removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Dec 14, 2021
@amnonbc
Copy link

amnonbc commented Jan 18, 2022

Effective Go is an excellent resource and should be kept current.

@ianlancetaylor
Copy link
Contributor

Not doing this per CL 380634.

@gopherbot
Copy link

Change https://golang.org/cl/380634 mentions this issue: content/doc: add an explanatory preamble to Effective Go

gopherbot pushed a commit to golang/website that referenced this issue Jan 30, 2022
@robpike
content/doc: add an explanatory preamble to Effective Go
a26b85f 
Explain that Effective Go is not a living document.
No changes other than one new paragraph in the
introduction.

Fixes golang/go#49937
Update golang/go#28782

Change-Id: I615e48df56313e3d91e8b88b139159f64900db7e
Reviewed-on: https://go-review.googlesource.com/c/website/+/380634
Reviewed-by: DO NOT USE <iant@google.com>
Trust: Michael Knyszek <mknyszek@google.com>
@rsc rsc unassigned robpike Jun 23, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/doc: add an explanatory preamble to Effective Go
d535517 
Explain that Effective Go is not a living document.
No changes other than one new paragraph in the
introduction.

Fixes golang/go#49937
Update golang/go#28782

Change-Id: I615e48df56313e3d91e8b88b139159f64900db7e
Reviewed-on: https://go-review.googlesource.com/c/website/+/380634
Reviewed-by: DO NOT USE <iant@google.com>
Trust: Michael Knyszek <mknyszek@google.com>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
8 participants
@mknyszek @ianlancetaylor @robpike @amnonbc @griesemer @gopherbot @cherrymui @susugagalala