Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDNSSRVUniformity failure on linux-386 #49933

Closed
bcmills opened this issue Dec 2, 2021 · 1 comment
Closed

net: TestDNSSRVUniformity failure on linux-386 #49933

bcmills opened this issue Dec 2, 2021 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 2, 2021

--- FAIL: TestDNSSRVUniformity (0.01s)
    dnsclient_test.go:31: actual: 5251 diff: 251 e: 5000 m: 0.05
    dnsclient_test.go:36: missed target weight: expected 5000, 5251
    dnsclient_test.go:31: actual: 3337 diff: 3.666666666666515 e: 3333.3333333333335 m: 0.1
    dnsclient_test.go:31: actual: 1031 diff: 31 e: 1000 m: 0.2
    dnsclient_test.go:31: actual: 5965 diff: -35 e: 6000 m: 0.05
FAIL
FAIL	net	27.391s

Looks like this run missed the target by one. It isn't obvious to me how the margins for this test were computed or what the expected false-failure rate is intended to be, but clearly they aren't quite high enough to avoid flakes entirely.

This test (including these hard-coded margins) was added in CL 88900044 (CC @bradfitz @msolo @rsc) for #7098.

greplogs --dashboard -md -l -e 'FAIL: TestDNSSRVUniformity'

2021-12-02T05:25:23-00dbcb3/linux-386-longtest

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 2, 2021
@bcmills bcmills added this to the Backlog milestone Dec 2, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Dec 2, 2021

Given only one failure in the logs, closing as “probably an outlier”.

@bcmills bcmills closed this as completed Dec 2, 2021
@golang golang locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants