Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: support more load commands on Mach-O [1.16 backport] #49923

Closed
mknyszek opened this issue Dec 2, 2021 · 7 comments
Closed

cmd/link: support more load commands on Mach-O [1.16 backport] #49923

mknyszek opened this issue Dec 2, 2021 · 7 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge OS-Darwin
Milestone
Go1.16.13

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Dec 2, 2021

On the 1.16 release branch, the macOS 12 builder has been failing since it was brought up, basically.

The failures look like https://build.golang.org/log/158c3565da1dabd522292bee52369d329419a452 with a bunch of misc/cgo/testcshared tests failing.

CC @cherrymui @ianlancetaylor
@mknyszek mknyszek added this to the Go1.16.11 milestone Dec 2, 2021
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 2, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Dec 2, 2021 •
edited
Loading

CC @golang/release in case this is a problem with the builder itself (#49149) or macOS 12.

@dmitshur dmitshur mentioned this issue Dec 2, 2021
Closed
@heschi
Copy link
Contributor

heschi commented Dec 2, 2021

Sorry for not paying attention when I brought up the builder. We're suffering for lack of https://golang.org/cl/312729. Should I disable the builder or backport that CL?

@ianlancetaylor
Copy link
Member

Since 1.16 is still supported I think we should backport.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/368835 mentions this issue: [release-branch.go1.16] cmd/link: support more load commands on Mach-O

@heschi heschi modified the milestones: Go1.16.11, Go1.16.12 Dec 2, 2021
@gopherbot
Copy link
Contributor

Closed by merging 98ef91b to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Dec 2, 2021
@cherrymui @heschi
[release-branch.go1.16] cmd/link: support more load commands on Mach-O
98ef91b 
Fixes #49923.

Change-Id: I74dd9170a51cc93ce3ec5e5860c2eb2912f081f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/312729
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit b6ff3c6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/368835
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Heschi Kreinick <heschi@google.com>
@dmitshur dmitshur changed the title cmd/link: several misc/cgo/testcshared tests failing in the linker on macOS 12 on the 1.16 release branch cmd/link: support more load commands on Mach-O [1.16 backport] Dec 3, 2021
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 3, 2021
@FiloSottile
Copy link
Contributor

Reverted to minimize risk for security release.

@FiloSottile FiloSottile reopened this Dec 9, 2021
@FiloSottile FiloSottile modified the milestones: Go1.16.12, Go1.16.13 Dec 9, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/372354 mentions this issue: Revert "Revert "[release-branch.go1.16] cmd/link: support more load commands on Mach-O""

@heschi heschi closed this as completed Dec 15, 2021
gopherbot pushed a commit that referenced this issue Dec 15, 2021
@heschi
[release-branch.go1.16] Reapply "cmd/link: support more load commands…
9364c89 
… on Mach-O"

This reverts commit caced3b (CL 370554).

Reason for revert: Minor release complete.

Updates #49923.

Change-Id: Ifb9fc4f6aae6313ce726726c4ec469032ed3147d
Reviewed-on: https://go-review.googlesource.com/c/go/+/372354
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
Trust: Heschi Kreinick <heschi@google.com>
@golang golang locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge OS-Darwin
Projects
None yet
Milestone
Go1.16.13
Development

No branches or pull requests
6 participants
@FiloSottile @mknyszek @dmitshur @ianlancetaylor @gopherbot @heschi