Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/benchmarks/sweet: build broken on plan9 as of CL 368195 via github.com/blevesearch/mmap-go and go.etcd.io/bbolt #49920

Closed
bcmills opened this issue Dec 2, 2021 · 1 comment
Closed

x/benchmarks/sweet: build broken on plan9 as of CL 368195 via github.com/blevesearch/mmap-go and go.etcd.io/bbolt #49920

bcmills opened this issue Dec 2, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-Plan9 release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 2, 2021 •
edited

https://build.golang.org/log/2269c5132da775893139d7296b45614e4463f908:

# github.com/blevesearch/mmap-go
../../../../pkg/mod/github.com/blevesearch/mmap-go@v1.0.2/mmap.go:77:9: undefined: mmap
../../../../pkg/mod/github.com/blevesearch/mmap-go@v1.0.2/mmap.go:92:11: m.lock undefined (type MMap has no field or method lock, but does have Lock)
../../../../pkg/mod/github.com/blevesearch/mmap-go@v1.0.2/mmap.go:99:11: m.unlock undefined (type MMap has no field or method unlock, but does have Unlock)
../../../../pkg/mod/github.com/blevesearch/mmap-go@v1.0.2/mmap.go:104:11: m.flush undefined (type MMap has no field or method flush, but does have Flush)
../../../../pkg/mod/github.com/blevesearch/mmap-go@v1.0.2/mmap.go:114:11: m.unmap undefined (type *MMap has no field or method unmap, but does have Unmap)
# go.etcd.io/bbolt
../../../../pkg/mod/go.etcd.io/bbolt@v1.3.5/db.go:223:12: undefined: flock
../../../../pkg/mod/go.etcd.io/bbolt@v1.3.5/db.go:360:12: undefined: mmap
../../../../pkg/mod/go.etcd.io/bbolt@v1.3.5/db.go:382:12: undefined: munmap
../../../../pkg/mod/go.etcd.io/bbolt@v1.3.5/db.go:462:12: undefined: fdatasync
../../../../pkg/mod/go.etcd.io/bbolt@v1.3.5/db.go:507:14: undefined: funlock
../../../../pkg/mod/go.etcd.io/bbolt@v1.3.5/db.go:867:37: undefined: fdatasync
../../../../pkg/mod/go.etcd.io/bbolt@v1.3.5/tx.go:559:13: undefined: fdatasync
../../../../pkg/mod/go.etcd.io/bbolt@v1.3.5/tx.go:596:13: undefined: fdatasync

This can be addressed in one of three ways:

  1. Fix the upstream package to build on this platform, then update the version requirement to use the fixed version.
  2. Add sufficient //go:build constraints so that the broken package is no longer built on this platform.
  3. Update the builder configuration to skip this platform for the entire x/benchmarks repo (see CL 368154 for an example of how to do so).

(attn @mknyszek @prattmic @dr2chase))
@bcmills bcmills added OS-Plan9 Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. release-blocker okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Dec 2, 2021
@bcmills bcmills added this to the Go1.18 milestone Dec 2, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Dec 2, 2021

Fixed by CL 368754.

@mknyszek mknyszek closed this as completed Dec 2, 2021
@golang golang locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-Plan9 release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@mknyszek @bcmills @gopherbot