Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: frequent failures in TestClientConnCloseAtBody [1.16 backport] #49910

Closed
gopherbot opened this issue Dec 1, 2021 · 3 comments
Closed

x/net/http2: frequent failures in TestClientConnCloseAtBody [1.16 backport] #49910

gopherbot opened this issue Dec 1, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.16.11

Comments

@gopherbot
Copy link

@neild requested issue #49335 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backport issues for 1.16 and 1.17. Test-only fix for flaky failures.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 1, 2021
@gopherbot gopherbot mentioned this issue Dec 1, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.11 milestone Dec 1, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/368554 mentions this issue: [internal-branch.go1.16-vendor] http2: don't count aborted streams as active in tests

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Dec 1, 2021
@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Approving because it's a test-only fix that improves the reliability of the release builders.

CC @dmitshur

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Dec 1, 2021
gopherbot pushed a commit to golang/net that referenced this issue Dec 1, 2021
@neild @mknyszek
[internal-branch.go1.16-vendor] http2: don't count aborted streams as…
64539c1 
… active in tests

Deflake TestClientConnCloseAtBody, which assumes all streams
have been fully cleaned up after ClientConn.Close returns.
Only count active streams, not ones in the process of aborting.

Perhaps ClientConn.Close should block until all streams have
been cleaned up, although this could result in Close blocking
indefinitely if a stream is blocked reading from the request body.

For golang/go#49335.
For golang/go#49910.

Change-Id: I172e0d3f10875191d29b24598de0abbdeb35e434
Reviewed-on: https://go-review.googlesource.com/c/net/+/361536
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit b53810d)
Reviewed-on: https://go-review.googlesource.com/c/net/+/368554
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 1, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/368594 mentions this issue: [release-branch.go1.16] net/http: update bundled golang.org/x/net/http2

@mknyszek mknyszek closed this as completed Dec 2, 2021
gopherbot pushed a commit that referenced this issue Dec 2, 2021
@mknyszek
[release-branch.go1.16] net/http: update bundled golang.org/x/net/http2
b29e772 
Pull in approved backports to golang.org/x/net/http2:

    64539c1 http2: don't count aborted streams as active in tests
    e677a40 ipv6: OpenBSD does not appear to support multicast loopback
    d8ae719 net/http2: Fix handling of expect continue
    cc2f99c http2: avoid busy loop when ResponseHeaderTimeout is set
    5533dda http2: avoid spurious RoundTrip error when server closes and resets stream
    26ec667 http2: close conns after use when req.Close is set

By doing:

    $ go get -d golang.org/x/net@internal-branch.go1.16-vendor
    go: downloading golang.org/x/net v0.0.0-20211201233224-64539c132272
    go get: upgraded golang.org/x/net v0.0.0-20211101194150-d8c3cde3c676 => v0.0.0-20211201233224-64539c132272
    $ go mod tidy
    $ go mod vendor
    $ go generate -run=bundle std

Fixes #49904.
Fixes #49623.
Fixes #49661.
Fixes #49560.
Fixes #49908.
Fixes #49910.

Change-Id: I73261b189f84cf1919a79129ec36a1c187723133
Reviewed-on: https://go-review.googlesource.com/c/go/+/368594
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.16.11
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot