Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: test failures with "change not found on Gerrit server" #49899

Closed
bcmills opened this issue Dec 1, 2021 · 9 comments
Closed

x/review/git-codereview: test failures with "change not found on Gerrit server" #49899

bcmills opened this issue Dec 1, 2021 · 9 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 1, 2021 

--- FAIL: TestSubmitInteractive (0.89s)
    submit_test.go:209: git-codereview submit -i
    submit_test.go:247: git-codereview submit
    submit_test.go:218: git-codereview submit -i
    submit_test.go:227: git-codereview submit -i
    util_test.go:345: died
        stdout:
        stderr:
        git-codereview: submitting 47d71d1 msg
        git-codereview: change not found on Gerrit server
FAIL
FAIL	golang.org/x/review/git-codereview	45.541s

greplogs --dashboard -md -l -e 'FAIL: TestSubmitInteractive.*\n(?:\s+.+)*.*change not found'

2021-11-29T19:46:17-39ade5b-b7651e5/dragonfly-amd64
2017-03-07T20:46:54-e973841-b992c26/openbsd-amd64-60

Not clear to me whether this is a Gerrit server flake or a bug in the test, but the failure rate is delightfully low. 😅
@gopherbot gopherbot added this to the Unreleased milestone Dec 1, 2021
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 1, 2021
@bcmills bcmills modified the milestones: Unreleased, Backlog Dec 1, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Dec 1, 2021 •
edited

Widening the failure regexp a bit to catch other tests, since this failure is attributed to util_test.go:

greplogs --dashboard -md -l -e '(?ms)change not found on Gerrit server.*FAIL\s+golang\.org/x/review/git-codereview' --since=2020-01-01

2021-11-29T19:46:17-39ade5b-b7651e5/dragonfly-amd64
2021-11-12T18:11:18-39ade5b-2dbf370/dragonfly-amd64
2021-11-04T21:52:06-39ade5b-37634ee/dragonfly-amd64
2021-10-27T13:12:49-39ade5b-cfb5321/dragonfly-amd64
2021-05-06T14:59:58-2465c8e-07d8cba/dragonfly-amd64
2021-02-05T22:35:11-28abaf5-b54cd94/dragonfly-amd64
2020-05-07T02:45:57-180dd7f-05e3ad3/dragonfly-amd64

@bcmills bcmills changed the title x/review/git-codereview: TestSubmitInteractive failures with "change not found on Gerrit server" x/review/git-codereview: test failures with "change not found on Gerrit server" Dec 1, 2021
@gopherbot
Copy link

Change https://golang.org/cl/368174 mentions this issue: git-codereview: log stderr and stdout from successful commands

gopherbot pushed a commit to golang/review that referenced this issue Dec 3, 2021
git-codereview: log stderr and stdout from successful commands
4305ba7 
The reason for the failures in golang/go#49899 is not clear.
Perhaps the stderr output will shed some light on what is happening.

For golang/go#49899

Change-Id: I37c6339c8ebd4a37e4ff5b3b813572193903cee4
Reviewed-on: https://go-review.googlesource.com/c/review/+/368174
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bcmills
Copy link
Contributor Author

bcmills commented Apr 5, 2022

The extra logging has not shed much light on the problem.

--- FAIL: TestSubmitMultiple (1.58s)
    submit_test.go:247: git-codereview submit
    submit_test.go:186: git-codereview submit b8ebf80fca94d23cfd73ea87a41a6bb74cd03d42 c6abb3a418db3c087eeab31d0eb6a40b237f3da5
    util_test.go:360: died
        stdout:
        stderr:
        git-codereview: submitting b8ebf80 msg
        git-codereview: change not found on Gerrit server
FAIL
FAIL	golang.org/x/review/git-codereview	207.714s

greplogs --dashboard -md -l -e '(?ms)change not found on Gerrit server.*FAIL\s+golang\.org/x/review/git-codereview' --since=2021-12-02

2022-04-02T17:45:45-543cc26-01c83be/solaris-amd64-oraclerel
2022-03-12T23:32:36-6c99688-842d37e/openbsd-amd64-68
2022-03-10T01:57:27-6c99688-00535b8/solaris-amd64-oraclerel
2022-01-13T23:04:22-b04b288-4f6f68e/openbsd-amd64-70
2021-12-14T01:48:22-b8ead20-1afa432/openbsd-amd64-70-n1

@bcmills
Copy link
Contributor Author

bcmills commented Apr 22, 2022

The logging from CL 399116 has added some interesting output!

git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir-host-dragonfly-amd64-master%2Ftmp%2Fgit-codereview-test110533653%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir-host-dragonfly-amd64-master%2Ftmp%2Fgit-codereview-test110533653%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir-host-dragonfly-amd64-master%2Ftmp%2Fgit-codereview-test110533653%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir-host-dragonfly-amd64-master%2Ftmp%2Fgit-codereview-test110533653%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir-host-dragonfly-amd64-master%2Ftmp%2Fgit-codereview-test110533653%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir-host-dragonfly-amd64-master%2Ftmp%2Fgit-codereview-test110533653%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir-host-dragonfly-amd64-master%2Ftmp%2Fgit-codereview-test110533653%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir-host-dragonfly-amd64-master%2Ftmp%2Fgit-codereview-test110533653%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/proj~main~I123456789?o=LABELS&o=CURRENT_REVISION: change not found on Gerrit server
git-codereview: fetch /a/changes/proj~main~I123456789?o=LABELS&o=CURRENT_REVISION: http://127.0.0.1:60208/a/changes/proj~main~I123456789?o=LABELS&o=CURRENT_REVISION: malformed json response
git-codereview: fetch /a/changes/proj~main~I0000002?o=CURRENT_REVISION&o=LABELS&o=DETAILED_LABELS: change not found on Gerrit server
git-codereview: fetch /a/changes/proj~main~I0000001?o=CURRENT_REVISION&o=LABELS&o=DETAILED_LABELS: change not found on Gerrit server
git-codereview: fetch /a/changes/proj~main~I0000002?o=CURRENT_REVISION&o=LABELS&o=DETAILED_LABELS: change not found on Gerrit server
git-codereview: fetch /a/changes/proj~main~I0000001?o=CURRENT_REVISION&o=LABELS&o=DETAILED_LABELS: change not found on Gerrit server
git-codereview: fetch /a/changes/proj~main~I0000001?o=LABELS&o=CURRENT_REVISION: change not found on Gerrit server
--- FAIL: TestSubmitInteractive (0.70s)
    submit_test.go:209: git-codereview submit -i
    submit_test.go:209: stderr:
        git-codereview: nothing to submit
    submit_test.go:247: git-codereview submit
    submit_test.go:218: git-codereview submit -i
    submit_test.go:218: stderr:
        git-codereview: nothing to submit
    submit_test.go:227: git-codereview submit -i
    util_test.go:360: died
        stdout:
        stderr:
        git-codereview: submitting 1f3366f msg
        git-codereview: change not found on Gerrit server
FAIL
FAIL	golang.org/x/review/git-codereview	47.083s

@bcmills bcmills mentioned this issue Apr 22, 2022
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Apr 25, 2022

A regexp for the above failure mode:

greplogs --dashboard -md -l -e 'unsupported protocol scheme ""' --since=2022-04-14

2022-04-22T17:22:12-ae62a0b-534a911/dragonfly-amd64
2022-04-21T18:22:57-ae62a0b-f95db21/dragonfly-amd64

@bcmills
Copy link
Contributor Author

bcmills commented May 9, 2022

greplogs -l -e 'unsupported protocol scheme ""' --since=2022-04-23
2022-05-06T21:07:37-ae62a0b-ac39dbd/dragonfly-amd64

@bcmills
Copy link
Contributor Author

bcmills commented May 11, 2022

greplogs -l -e 'change not found on Gerrit server' --since=2022-05-07
2022-05-10T21:56:21-ae62a0b-bda9da8/netbsd-amd64-9_0

git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test1400654653%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test1400654653%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test1400654653%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test1400654653%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test1400654653%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test1400654653%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test1400654653%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test1400654653%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Aproj~main~I0000000004&q=change%3Aproj~main~I0000000003&q=change%3Aproj~main~I0000000002&q=change%3Aproj~main~I0000000001&q=change%3Aproj~main~I123456789: Get "http://127.0.0.1:65520/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Aproj~main~I0000000004&q=change%3Aproj~main~I0000000003&q=change%3Aproj~main~I0000000002&q=change%3Aproj~main~I0000000001&q=change%3Aproj~main~I123456789": dial tcp 127.0.0.1:65520: connect: connection reset by peer
…
git-codereview: fetch /a/changes/proj~main~I123456789?o=LABELS&o=CURRENT_REVISION: change not found on Gerrit server

@bcmills bcmills mentioned this issue Aug 31, 2022
Closed
@mknyszek mknyszek mentioned this issue Sep 6, 2022
Closed
@mknyszek
Copy link
Contributor

mknyszek commented Sep 6, 2022

2022-09-05T21:39:28-0c548b8-4c1ca42/dragonfly-amd64-622

@bcmills bcmills mentioned this issue Jun 14, 2023
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Jun 14, 2023

Duplicate of #56221

@bcmills bcmills marked this as a duplicate of #56221 Jun 14, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@mknyszek @bcmills @gopherbot