Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: preserve playground backend choice on "share" #49885

Closed
fzipp opened this issue Nov 30, 2021 · 2 comments
Closed

x/website: preserve playground backend choice on "share" #49885

fzipp opened this issue Nov 30, 2021 · 2 comments
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@fzipp
Copy link
Contributor

fzipp commented Nov 30, 2021 •
edited
Loading

CL 366056 added support for multiple backends to the playground.

When I choose "Go dev branch" and click "Share" the selection jumps back to "Go release". It would be nice if the choice was preserved, maybe even as part of the shareable URL.
@gopherbot gopherbot added this to the Unreleased milestone Nov 30, 2021
@fzipp fzipp changed the title x/website: preserve backend choice on "share" x/website: preserve playground backend choice on "share" Nov 30, 2021
@mknyszek mknyszek added FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 30, 2021
@mknyszek
Copy link
Contributor

CC @rsc

@rsc
Copy link
Contributor

rsc commented Nov 30, 2021

The jumping back is a duplicate of #49766, which has a fix pending.

We considered putting the Go version into the share URL but it would be a moving target and would lead to stale or strangely behaving links.

@rsc rsc closed this as completed Nov 30, 2021
@seankhliao seankhliao mentioned this issue Dec 2, 2021
Closed
@golang golang locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@rsc @fzipp @mknyszek @gopherbot