Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/tour: broken links between pages #49880

Closed
memark opened this issue Nov 30, 2021 · 3 comments
Closed

x/website/tour: broken links between pages #49880

memark opened this issue Nov 30, 2021 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@memark
Copy link

memark commented Nov 30, 2021

What did you do?

Go to a tour page with an site-internal link, e.g.

Click the link

What did you expect to see?

Successful navigation to the new page

What did you see instead?

404

It appears the URL segment "/tour" is missing from all internal links.
@gopherbot gopherbot added this to the Unreleased milestone Nov 30, 2021
@mknyszek
Copy link
Contributor

CC @rsc whose been looking at other small go.dev improvements.

@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 30, 2021
@mknyszek
Copy link
Contributor

The links are indeed broken.

@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 30, 2021
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 30, 2021
@gopherbot
Copy link

Change https://golang.org/cl/368034 mentions this issue: _content/tour: fix links, fix CSP policy for tour

passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content/tour: fix links, fix CSP policy for tour
97c0702 
Some links were missing the /tour/ at the front.

The tour also has links like <a href="javascript:next()">, which require
us to set unsafe-inline (or else enumerate the SHA256 of every link)
in the CSP header.

Also make the local server a bit more tour-friendly.

Fixes golang/go#49880.

Change-Id: Ice746571db1a34e1c02b4b2a16c4e9f30dc164d1
Reviewed-on: https://go-review.googlesource.com/c/website/+/368034
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
@golang golang locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@memark @mknyszek @gopherbot