Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash/adler32: TestGolden failures on freebsd starting 2021-11-26 #49862

Closed
bcmills opened this issue Nov 29, 2021 · 4 comments
Closed

hash/adler32: TestGolden failures on freebsd starting 2021-11-26 #49862

bcmills opened this issue Nov 29, 2021 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-FreeBSD release-blocker
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 29, 2021

greplogs --dashboard -md -l -e FAIL\\s+hash/adler32\\s+ --since=2020-01-01

2021-11-29T19:45:58-f598e29/freebsd-amd64-12_2
2021-11-26T13:18:11-7703804/freebsd-amd64-12_2

This may be another symptom of #46272 (CC @mknyszek @jeremyfaller), but it seems suspicious to see two such failures within a week and none at all for a year preceding.

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD labels Nov 29, 2021
@bcmills bcmills added this to the Go1.18 milestone Nov 29, 2021
@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Nov 29, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Nov 29, 2021

Marking as release-blocker at least until we understand whether this is a recent regression.

@toothrot
Copy link
Contributor

toothrot commented Dec 8, 2021

Checking on this as a release blocker. Are there any updates? @mknyszek

@bcmills
Copy link
Contributor Author

bcmills commented Dec 8, 2021

One more since then, same day as the previous one:

greplogs --dashboard -md -l -e FAIL\\s+hash/adler32\\s+ --since=2021-11-29T19:45:59

2021-11-29T22:02:45-1970e3e/freebsd-amd64-13_0

@aclements
Copy link
Member

This has to be memory corruption. The test is passing 1e5 0s to

func checksum(p []byte) uint32 {
	s1, s2 := uint32(1), uint32(0)
	for _, x := range p {
		s1 = (s1 + uint32(x)) % mod
		s2 = (s2 + s1) % mod
	}
	return s2<<16 | s1
}

and getting the wrong answer sometimes.

I find it very interesting that 2021-11-29T19:45:58-f598e29/freebsd-amd64-12_2 and 2021-11-29T22:02:45-1970e3e/freebsd-amd64-13_0 got the same wrong answer.

Since this can only be memory corruption, closing as a dup of #46272. I'll leave a comment on that bug because this is a potentially interesting test case.

@golang golang locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-FreeBSD release-blocker
Projects
None yet
Development

No branches or pull requests

4 participants