Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httptest: Close does not wait for the underlying Server's ConnState callbacks to complete [1.16 backport] #49851

Closed
gopherbot opened this issue Nov 29, 2021 · 3 comments
Closed

net/http/httptest: Close does not wait for the underlying Server's ConnState callbacks to complete [1.16 backport] #49851

gopherbot opened this issue Nov 29, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.16.11

Comments

@gopherbot
Copy link

@bcmills requested issue #37510 to be considered for backport to the next 1.16 minor release.

@gopherbot, please backport to Go 1.16. This may be the root cause of the test failure observed in #49850.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 29, 2021
@gopherbot gopherbot mentioned this issue Nov 29, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.11 milestone Nov 29, 2021
@bcmills bcmills mentioned this issue Nov 29, 2021
Closed
@bcmills
Copy link
Contributor

bcmills commented Nov 29, 2021

Marking as release-blocker via #11811, since this seems like the most straightforward way to clear the current failure on the linux-amd64-race builder for the x/net repo.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Dec 1, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/367516 mentions this issue: [release-branch.go1.16] net/http/httptest: wait for user ConnState hooks

gopherbot pushed a commit that referenced this issue Dec 1, 2021
@neild @mknyszek
[release-branch.go1.16] net/http/httptest: wait for user ConnState hooks
0f9838e 
Ensure that user ConnState callbacks have completed before returning
from (*httptest.Server).Close.

Fixes: #49851
Updates: #37510
Updates: #37505
Updates: #45237

Change-Id: I8fe7baa089fbe4f3836bf6ae9767c7b1270d1331
Reviewed-on: https://go-review.googlesource.com/c/go/+/304829
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 5cec8b8)
Reviewed-on: https://go-review.googlesource.com/c/go/+/367516
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Landed the fix.

@mknyszek mknyszek closed this as completed Dec 1, 2021
@golang golang locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.16.11
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @bcmills @gopherbot