Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Links to code hosted on GitLab under a sub-group are invalid #49827

Closed
mitar opened this issue Nov 28, 2021 · 9 comments
Closed

x/pkgsite: Links to code hosted on GitLab under a sub-group are invalid #49827

mitar opened this issue Nov 28, 2021 · 9 comments
Labels
FrozenDueToAge pkgsite
Milestone
pkgsite/unplanned

Comments

@mitar
Copy link
Contributor

mitar commented Nov 28, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/gitlab.com/tozd/go/errors

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0

What did you do?

  1. Go to https://pkg.go.dev/gitlab.com/tozd/go/errors#As
  2. Click on the link function link, which points to the source code

What did you expect to see?

I expected to see the source code available under https://gitlab.com/tozd/go/errors/blob/<commit>/stdlib.go#L47.

What did you see instead?

I was directed to invalid https://gitlab.com/tozd/go/blob/<commit>/errors/stdlib.go#L47.
@gopherbot gopherbot added this to the pkgsite/unplanned milestone Nov 28, 2021
@mitar
Copy link
Contributor Author

mitar commented Nov 28, 2021 •
edited

This looks correct:

curl -s https://gitlab.com/tozd/go/errors?go-get=1

<html>
<head>
<meta name="go-import" content="gitlab.com/tozd/go/errors git https://gitlab.com/tozd/go/errors.git" />
<meta name="go-source" content="gitlab.com/tozd/go/errors https://gitlab.com/tozd/go/errors https://gitlab.com/tozd/go/errors/-/tree/main{/dir} https://gitlab.com/tozd/go/errors/-/blob/main{/dir}/{file}#L{line}" />
</head>
<body>go get https://gitlab.com/tozd/go/errors</body>
</html>

@jamalc
Copy link

jamalc commented Dec 10, 2021

I don't have a gitlab account and the link is behind an auth wall, can anyone else verify this issue? cc/ @jba @julieqiu

@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 10, 2021
@jba jba self-assigned this Dec 10, 2021
@mitar
Copy link
Contributor Author

mitar commented Dec 10, 2021

Sorry, what auth wall? There should be no auth wall? Project and link are public?

@mitar
Copy link
Contributor Author

mitar commented Dec 10, 2021

So curl above works for me without any authentication.

@jamalc
Copy link

jamalc commented Dec 10, 2021

My mistake, the bad URL from the function source link brought me to a Gitlab sign-in page.

@gopherbot
Copy link

Change https://golang.org/cl/375281 mentions this issue: internal/source: fix gitlab patterns

@jba
Copy link
Contributor

jba commented Jan 5, 2022

Just to be clear: this has been fixed in the source. The actual pkg.go.dev links won't work until we deploy and then reprocess the broken modules.

I'm going to reopen this until that's done.

@jba jba reopened this Jan 5, 2022
@jba jba removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 5, 2022
@mitar
Copy link
Contributor Author

mitar commented Jan 5, 2022

Awesome! Thank you for the quick fix!

@jba
Copy link
Contributor

jba commented Jan 10, 2022

Fixed live.

@jba jba closed this as completed Jan 10, 2022
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@mitar @gopherbot @jamalc @jba