net/http: *http.Request RemoteAddr returns "@"(at sign) when HTTP server serving on unix listener #49825

sunshineplan · 2021-11-28T09:21:11Z

What version of Go are you using (`go version`)?

$ go version
go version go1.17.3 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=%USERPROFILE%\AppData\Local\go-build
set GOENV=%USERPROFILE%\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=%USERPROFILE%\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=%USERPROFILE%\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.17.3
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=%USERPROFILE%\Desktop\test\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=%USERPROFILE%\AppData\Local\Temp\go-build2198432139=/tmp/go-build -gno-record-gcc-switches

What did you do?

package main

import (
	"bufio"
	"context"
	"io"
	"log"
	"net"
	"net/http"
	"os"
)

const (
	network = "unix"
	address = "unix"
)

var srv = new(http.Server)

func main() {
	server()
	client()
	srv.Shutdown(context.Background())
	os.Remove(address)
}

func server() {
	listener, err := net.Listen(network, address)
	if err != nil {
		log.Fatal(err)
	}

	srv.Handler = http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		w.Write([]byte(r.RemoteAddr))
	})
	go srv.Serve(listener)
}

func client() {
	conn, err := net.Dial(network, address)
	if err != nil {
		log.Fatal(err)
	}

	req, err := http.NewRequest("GET", "/", nil)
	if err != nil {
		log.Fatal(err)
	}
	req.Write(conn)
	br := bufio.NewReader(conn)
	resp, err := http.ReadResponse(br, req)
	if err != nil {
		conn.Close()
		log.Fatal(err)
	}
	b, err := io.ReadAll(resp.Body)
	if err != nil {
		log.Fatal(err)
	}
	log.Print(string(b))
	conn.Close()
}

https://go.dev/play/p/zc8rsEC6Jeb

What did you expect to see?

2009/11/10 23:00:00 unix

What did you see instead?

2009/11/10 23:00:00 @
#gin-gonic/gin#2962

The text was updated successfully, but these errors were encountered:

seankhliao · 2021-11-28T13:45:34Z

See:

go/src/syscall/syscall_linux.go

Lines 506 to 511 in 0fa53e4

    
           // "Abstract" Unix domain socket. 
        
           // Rewrite leading NUL as @ for textual display. 
        
           // (This is the standard convention.) 
        
           // Not friendly to overwrite in place, 
        
           // but the callers below don't care. 
        
           pp.Path[0] = '@'

The syscall returns a null byte, "unix" would be wrong since it could be an actual path

seankhliao closed this as completed Nov 28, 2021

sunshineplan mentioned this issue Nov 29, 2021

Default log cannot record remote ip address when nginx proxy pass to unix address gin-gonic/gin#2962

Closed

golang locked and limited conversation to collaborators Nov 28, 2022

gopherbot added the FrozenDueToAge label Nov 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net/http: *http.Request RemoteAddr returns "@"(at sign) when HTTP server serving on unix listener #49825

net/http: *http.Request RemoteAddr returns "@"(at sign) when HTTP server serving on unix listener #49825

sunshineplan commented Nov 28, 2021

seankhliao commented Nov 28, 2021

net/http: *http.Request RemoteAddr returns "@"(at sign) when HTTP server serving on unix listener #49825

net/http: *http.Request RemoteAddr returns "@"(at sign) when HTTP server serving on unix listener #49825

Comments

sunshineplan commented Nov 28, 2021

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

seankhliao commented Nov 28, 2021

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?