You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If there's a printf format specifier error, govet exits with status 1. If there's a
struct field tag incompatible with reflect.StructTag.Get, govet exits with 0. The other
vet checks do a mix of those. It should be made consistent so other tooling can depend
on it.
The text was updated successfully, but these errors were encountered:
Can you be more specific? There is one that should be fixed (Printf(os.Stderr) gives
only a warning) but the only other Warnf call in print.go is a type-checking failure
that is unlikely unless go/types failed on the package. In that case the diagnosis is
really only a warning.
There are a few Warnf calls in other modules that should be made Badf but you explicitly
called out print checking.
I called out print checking, not because it's necessarily wrong, but because I noticed
it was different to some others. Is it your intention that govet should exit with 1 if
there are problems it finds? That sounds okay to me, but (1) it should be documented,
and (2) the few warnings that don't use Badf should be fixed. It just wasn't clear to me
what the exit value semantics were supposed to be.
The text was updated successfully, but these errors were encountered: