Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: 'Implements' API does not consider structural restrictions #49786

Closed
findleyr opened this issue Nov 24, 2021 · 1 comment
Closed

go/types, types2: 'Implements' API does not consider structural restrictions #49786

findleyr opened this issue Nov 24, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.18

Comments

@findleyr
Copy link
Contributor

This was an oversight: our types.Implements predicate does not currently use the internal implements predicate from CL 363837, and therefore doesn't compare type sets.

This is trivial but needs to be fixed, and should be a release-blocker.

CC @griesemer
@findleyr findleyr added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Nov 24, 2021
@findleyr findleyr added this to the Go1.18 milestone Nov 24, 2021
@findleyr findleyr self-assigned this Nov 24, 2021
@gopherbot
Copy link

Change https://golang.org/cl/367515 mentions this issue: go/types: consider structural restrictions in Implements

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@gopherbot @findleyr