Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: crypto/cipher: GCM for stream encryption #49782

Closed
JonasJasas opened this issue Nov 24, 2021 · 3 comments
Closed

proposal: crypto/cipher: GCM for stream encryption #49782

JonasJasas opened this issue Nov 24, 2021 · 3 comments
Labels
FrozenDueToAge Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone
Proposal

Comments

@JonasJasas
Copy link

Feature request:

add support for stream encryption in GCM. It is not possible (or at least I didn't find out how) to create Reader/Writter that encrypts stream using crypto/cipher.
@seankhliao seankhliao changed the title crypto/cipher: GCM for stream encryption proposal: crypto/cipher: GCM for stream encryption Nov 24, 2021
@gopherbot gopherbot added this to the Proposal milestone Nov 24, 2021
@seankhliao seankhliao added the Proposal-Crypto Proposal related to crypto packages or other security issues label Nov 24, 2021
@seankhliao
Copy link
Member

cc @FiloSottile

@ianlancetaylor ianlancetaylor added this to Incoming in Proposals (old) Nov 24, 2021
@ericlagergren
Copy link
Contributor

I assume a streaming AEAD won't be added to the stdlib, so here here are some examples of how to do this. If you have to ask how to do this, then I recommend using Google Tink.

  1. https://github.com/google/tink/blob/9753ffddd4d04aa56e0605ff4a0db46f2fb80529/go/streamingaead/subtle/aes_gcm_hkdf.go
  2. https://github.com/FiloSottile/age/blob/a21c212358e041b27e759493b9feb4f78303bf49/internal/stream/stream.go
  3. https://github.com/ericlagergren/stream/blob/4d176b1a87c63b61b31a85c10a6f49e2064642aa/stream.go

@FiloSottile
Copy link
Contributor

Duplicate of #43774.

@FiloSottile FiloSottile mentioned this issue Jan 4, 2022
Closed
@seankhliao seankhliao removed this from Incoming in Proposals (old) Jul 3, 2022
@golang golang locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
5 participants
@FiloSottile @ericlagergren @gopherbot @seankhliao @JonasJasas