Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: "Try Go" on the main page uses the scrollbar for no apparent reason #49770

Closed
mvdan opened this issue Nov 23, 2021 · 2 comments
Closed

x/website: "Try Go" on the main page uses the scrollbar for no apparent reason #49770

mvdan opened this issue Nov 23, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@mvdan
Copy link
Member

mvdan commented Nov 23, 2021

image

It seems like the code has a trailing empty line. If I remove it, it helps, but the scrollbar still just barely stays around, moving the textbox up and down by just a few pixels.

The code clearly fits there, even if we need to make the textbox slightly taller. The page would look a lot better without the scrollbar. It also had me do a double take and wonder if there was extra code worth scrolling down for.
@mvdan
Copy link
Member Author

mvdan commented Nov 23, 2021

I should clarify this is on Firefox 94.0.2.

@gopherbot gopherbot added this to the Unreleased milestone Nov 23, 2021
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 24, 2021
@rsc rsc self-assigned this Nov 24, 2021
@gopherbot
Copy link

Change https://golang.org/cl/366995 mentions this issue: go.dev: hide annoying vertical scroll bar in Try Go hello world

@rsc rsc removed their assignment Jun 23, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
go.dev: hide annoying vertical scroll bar in Try Go hello world
f5dc278 
The window is sized properly to hold the text but we still
get a scroll bar that wiggles the text box a line or so.
Make it disappear.

Also correct the descriptions of the nearby buttons.

Fixes golang/go#49770.

Change-Id: I2c0ee6cba3b3160aa0666c3e48566f2f4940b3db
Reviewed-on: https://go-review.googlesource.com/c/website/+/366995
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@rsc @mvdan @gopherbot @heschi