Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: some important pages seem to not be linked to #49768

Closed
mvdan opened this issue Nov 23, 2021 · 5 comments
Closed

x/website: some important pages seem to not be linked to #49768

mvdan opened this issue Nov 23, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@mvdan
Copy link
Member

mvdan commented Nov 23, 2021

For example, https://go.dev/doc/contribute is an invaluable resource for contributing to Go, but I can't find it under https://go.dev/doc/.

I imagine other pages also fell off the radar given the website redesign, but I'm not sure how to check.
@gopherbot gopherbot added this to the Unreleased milestone Nov 23, 2021
@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 24, 2021
@rsc
Copy link
Contributor

rsc commented Nov 24, 2021

There shouldn't be very many unlinked pages, since all the content on golang.org moved over verbatim except for the front page. Looking at the old front page, the old header linked to /project and /help/, which may not have links anymore. I've put both of them into the footer in CL 366577. Thanks!

@rsc rsc self-assigned this Nov 24, 2021
@gopherbot
Copy link

Change https://golang.org/cl/366577 mentions this issue: _content: adjust footer

@fzipp
Copy link
Contributor

fzipp commented Nov 24, 2021

The "Contribution Guide" is reachable via the website, but it's deeply buried:

"Docs" -> "Installing Go" -> "Installing Go from source" -> "(Optional) Switch to the master branch" -> "contribute your changes"

I think it was the same on the old website, so it's not a regression.

@mvdan
Copy link
Member Author

mvdan commented Nov 24, 2021

Ah, so now "About" will point to https://go.dev/project, which does have a direct link to the contribution guide. That seems like a big improvement, thanks!

I think it was the same on the old website, so it's not a regression.

That's entirely fair - I don't recall exactly the layout of the old site, and I don't have a way to check easily now that the site redirects.

@JeremyLoy
Copy link

JeremyLoy commented Nov 26, 2021 •
edited

There also doesn’t seem to be a link to the standard library either

IIRC clicking packages in the hamburger menu used to bring you to this page

now, it brings you to the pkg.go.dev search

the old page was at /pkg but the new page is at /std so this actually might just be a case of a bad redirect

@ALTree ALTree mentioned this issue Nov 29, 2021
Closed
@rsc rsc removed their assignment Jun 23, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content: adjust footer
b534d56 
Change footer About heading to link to /project.
Linking to /about was always mainly about pkg.go.dev,
and now it redirects to pkg.go.dev/about, so that's clearly wrong.
But we need a link to somewhere, and we also need a link to /project
(which used to a be a top-level heading on golang.org),
so it's a good match.

Add Standard Library to Packages section.

Add Help to Get Started section.
(Used to be a top-level heading on golang.org.)

For golang/go#40785 (but probably more to do there).
Fixes golang/go#49737.
Fixes golang/go#49768.

Change-Id: I4a0837aaaa89b3bd79bda7a55bcff3a5ef9e206b
Reviewed-on: https://go-review.googlesource.com/c/website/+/366577
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@rsc @fzipp @mvdan @gopherbot @JeremyLoy @heschi