Skip to content

x/website: download button only knows about macOS and Windows #49765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cespare opened this issue Nov 23, 2021 · 6 comments
Closed

x/website: download button only knows about macOS and Windows #49765

cespare opened this issue Nov 23, 2021 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@cespare
Copy link
Contributor

cespare commented Nov 23, 2021

What is the URL of the page with the issue?

https://go.dev/, for example

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36

Screenshot

screen_20211123133124

What did you do?

Clicked the download button on the front page using a Linux machine

What did you expect to see?

A Linux tarball

What did you see instead?

A Windows MSI

Reported on Twitter by @dominikh.
@gopherbot gopherbot added this to the Unreleased milestone Nov 23, 2021
@mvdan
Copy link
Member

mvdan commented Nov 23, 2021

I can reproduce. How was the new website tested against the old site for regressions? There's also #49754, for example.

@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 24, 2021
@rsc
Copy link
Contributor

rsc commented Nov 24, 2021

This is not a regression.
This part of https://go.dev/ has been like this for a very long time.
People are just paying more attention to it now.
Will fix.

@mvdan
Copy link
Member

mvdan commented Nov 24, 2021

I meant regression as in: new users navigating to golang.org on Linux no longer get a Linux download button by default :)

@rsc
Copy link
Contributor

rsc commented Nov 24, 2021

Indeed. It's much worse that go.dev has always been like that!

@rsc rsc self-assigned this Nov 24, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/366976 mentions this issue: _content: remove go.dev download button "smarts"

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/366975 mentions this issue: _content: fix download button on non-Mac, non-Windows browsers

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 25, 2021
@rsc rsc removed their assignment Jun 23, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
_content: remove go.dev download button "smarts"
082fe9f 
The go.dev front page download button changes what links to
based on JS: if this is a Mac, it links to the darwin/amd64 pkg.
Otherwise it links to the windows/amd64 msi.

This is obviously wrong on all non-Mac, non-Windows systems,
such as Linux, FreeBSD, phones, tablets, and so on.
None of them want the Windows MSI.

It is also less obviously wrong on all arm64 Mac and Windows systems,
of which there will be more and more.

Changing whether the button downloads a file or goes to a new page
based on browser properties also makes it very difficult to write
documentation about how to install Go, since "click Download"
does different things for different people.

It's also very difficult to tell what architecture the browser is, by design.
So our chance of linking to the right download is going to plummet as
arm64-based systems proliferate.

Instead, just link to the download page and let people find what they need.

Fixes golang/go#49765.

Change-Id: I0761fddffaef3a36087fd050ae276111339ea2dc
Reviewed-on: https://go-review.googlesource.com/c/website/+/366976
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@rsc @cespare @dmitshur @mvdan @gopherbot @heschi