Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: Download Go button on go.dev/doc/install page is broken, still points to golang.org #49726

Closed
Pokom opened this issue Nov 22, 2021 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@Pokom
Copy link

Pokom commented Nov 22, 2021

What is the URL of the page with the issue?

https://go.dev/doc/install

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36 Edg/96.0.1054.29

Screenshot

image

What did you do?

I tried to click the button to download the Windows installer.

What did you expect to see?

The windows installer start to download.

What did you see instead?

image

@gopherbot gopherbot added this to the Unreleased milestone Nov 22, 2021
@seankhliao
Copy link
Member

seankhliao commented Nov 22, 2021

cc @rsc @dmitshur
looks like missing content security policy for golang.org/dl/?mode=json
or it should go to go.dev/dl/?mode=json?

@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 22, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Nov 22, 2021

Also, the link is to "golang.org/dl/" but should likely be updated to "go.dev/dl/". CC @rsc, @jamalc.

@dmitshur dmitshur changed the title x/website: install windows broken x/website: Download Go button on go.dev/doc/install page is broken, still points to golang.org Nov 22, 2021
@rsc rsc self-assigned this Nov 23, 2021
@gopherbot
Copy link

Change https://golang.org/cl/366394 mentions this issue: _content/doc: fix download buttons for go.dev/dl/

@rsc rsc removed their assignment Jun 23, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
Must use relative path to get to download site.
(https://go.dev/ would work most of the time,
but not when using golang.google.cn/dl/.)

Fixes golang/go#49726.

Change-Id: I8b47f5692eabf172bf45a48ce32c927ed705199c
Reviewed-on: https://go-review.googlesource.com/c/website/+/366394
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants