Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: "fatal error: unexpected signal during runtime execution" in cmd/go tests on darwin-amd64-race running macOS 12.0 #49723

Closed
bcmills opened this issue Nov 22, 2021 · 12 comments
Closed

runtime: "fatal error: unexpected signal during runtime execution" in cmd/go tests on darwin-amd64-race running macOS 12.0 #49723

bcmills opened this issue Nov 22, 2021 · 12 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 22, 2021

greplogs --dashboard -md -l -e '(?m)\Adarwin-(?:.*\n)+^signal arrived during cgo execution' --since=2021-01-01

2021-11-22T16:53:57-cd0bf38/darwin-amd64-race
2021-11-22T16:15:36-6275b54/darwin-amd64-race

I don't see any CLs in the repo that would explain this failure, so I suspect that it was triggered by the darwin-amd64-race configuration change in CL 365777 for #49149 (CC @golang/release).
@bcmills bcmills added OS-Darwin NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 22, 2021
@bcmills bcmills added this to the Go1.18 milestone Nov 22, 2021
@bcmills bcmills mentioned this issue Nov 22, 2021
Closed
@cherrymui
Copy link
Member

The environment printed at the top doesn't seem to have MallocNanoZone=0.

@gopherbot
Copy link

Change https://golang.org/cl/366136 mentions this issue: dashboard: move MallocNanoZone to host configuration

@heschi
Copy link
Contributor

heschi commented Nov 22, 2021

Deployed, cleared failed build, watching the dashboard.

@heschi
Copy link
Contributor

heschi commented Nov 22, 2021

Looks like mostly a success, but the cmd/go tests are failing, I would wager because they clear the environment. @bcmills should I file a bug?

@bcmills
Copy link
Contributor Author

bcmills commented Nov 22, 2021

If you like, or we can reopen this one. Should be an easy fix, but we'll presumably need to backport it too.

@heschi heschi reopened this Nov 22, 2021
@heschi heschi changed the title runtime: "signal arrived during cgo execution" on darwin-amd64-race running macOS 12.0 runtime: "fatal error: unexpected signal during runtime execution" in cmd/go tests on darwin-amd64-race running macOS 12.0 Nov 22, 2021
@heschi
Copy link
Contributor

heschi commented Nov 22, 2021

example: https://build.golang.org/log/fc6170578af96cfeeac255e6670f1fef33468742

@bcmills
Copy link
Contributor Author

bcmills commented Nov 22, 2021

@gopherbot, please backport to Go 1.16 and 1.17. This works around a regression in macOS 12.0.

@gopherbot
Copy link

Change https://golang.org/cl/366254 mentions this issue: cmd/go: forward the MallocNanoZone variable to script tests

@gopherbot gopherbot mentioned this issue Nov 22, 2021
Closed
@gopherbot
Copy link

Backport issue(s) opened: #49728 (for 1.16), #49729 (for 1.17).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@gopherbot gopherbot mentioned this issue Nov 22, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/366257 mentions this issue: [release-branch.go1.17] cmd/go: forward the MallocNanoZone variable to script tests

@gopherbot
Copy link

Change https://golang.org/cl/366258 mentions this issue: [release-branch.go1.16] cmd/go: forward the MallocNanoZone variable to script tests

@bcmills
Copy link
Contributor Author

bcmills commented Nov 22, 2021

cmd/go fix is in, and I've got TryBots running on the backports. (They'll also be ready to merge as soon as the TryBots finish.)

gopherbot pushed a commit that referenced this issue Nov 22, 2021
@heschi
[release-branch.go1.16] cmd/go: forward the MallocNanoZone variable t…
7da9659 
…o script tests

For #49138
Updates #49723
Fixes #49728

Change-Id: Ia93130fdc042a1e2107be95cccd7e7eeaa909a87
Reviewed-on: https://go-review.googlesource.com/c/go/+/366254
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 189b4a2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/366258
TryBot-Result: Go Bot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Nov 22, 2021
@heschi
[release-branch.go1.17] cmd/go: forward the MallocNanoZone variable t…
364f15f 
…o script tests

For #49138
Updates #49723
Fixes #49729

Change-Id: Ia93130fdc042a1e2107be95cccd7e7eeaa909a87
Reviewed-on: https://go-review.googlesource.com/c/go/+/366254
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 189b4a2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/366257
TryBot-Result: Go Bot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @cherrymui @heschi