Skip to content

x/exp/maps: approximation constraint element missing in signature of Copy function #49698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fzipp opened this issue Nov 20, 2021 · 1 comment
Closed

x/exp/maps: approximation constraint element missing in signature of Copy function #49698

fzipp opened this issue Nov 20, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@fzipp
Copy link
Contributor

fzipp commented Nov 20, 2021

The approximation constraint element is missing in the signature of the Copy function of the new golang.org/x/exp/maps package (#47649):

https://cs.opensource.google/go/x/exp/+/master:maps/maps.go;l=77;drc=c35f6fddc5c3a7c1ed8c5dcb28ad3390168abcda

What did you expect to see?

func Copy[M ~map[K]V, K comparable, V any](dst, src M)

What did you see instead?

func Copy[M map[K]V, K comparable, V any](dst, src M)
@gopherbot gopherbot added this to the Unreleased milestone Nov 20, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/365575 mentions this issue: maps: turn map constraint of Copy function into an approximation element

@ALTree ALTree added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Nov 20, 2021
@golang golang locked and limited conversation to collaborators Nov 21, 2022
misak113 pushed a commit to misak113/exp that referenced this issue Mar 14, 2025
@fzipp @misak113
maps: turn map constraint of Copy function into an approximation element
de8cdd2 
Fixes golang/go#49698

Change-Id: I62e25f11695d2a2729588dbb559ec6e144beb5a2
Reviewed-on: https://go-review.googlesource.com/c/exp/+/365575
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@fzipp @ALTree @gopherbot