Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/cipher: add BlockReader and BlockWriter interfaces #4968

Closed
gopherbot opened this issue Mar 2, 2013 · 7 comments
Closed

crypto/cipher: add BlockReader and BlockWriter interfaces #4968

gopherbot opened this issue Mar 2, 2013 · 7 comments
Labels
FrozenDueToAge
Milestone
Go1.2

Comments

@gopherbot
Copy link

by fasching.matthias:

Similarly to the StreamReader and StreamWriter interfaces in crypto/cipher BlockReader
and BlockWriter should be implemented to ease the use of block based ciphers such as CBC
or ECB.
@rsc
Copy link
Contributor

rsc commented Mar 12, 2013

Comment 1:

[The time for maybe has passed.]

Labels changed: removed go1.1maybe.

@davecheney
Copy link
Contributor

Comment 2:

Labels changed: added priority-later, removed priority-triage.

Status changed to HelpWanted.

@gopherbot
Copy link
Author

Comment 3 by fasching.matthias:

I started working on this Issue. Here is the codereview link for my initial change:
https://golang.org/cl/7854045/

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 4:

Marking this Go1.2Maybe but I have my doubts, especially after agl's comment on CL
7854045.

Labels changed: added go1.2maybe.

@agl
Copy link
Contributor

agl commented Jul 30, 2013

Comment 5:

I don't believe that we should ever support ECB mode. It's a very dangerous mode and, if
you know enough to use it right, then implementing it is trivial.
CBC is likewise dangerous. It's ok in a composite encrypt-then-MAC, AEAD construction,
but not really otherwise.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 6:

Labels changed: added feature.

@robpike
Copy link
Contributor

robpike commented Aug 19, 2013

Comment 7:

Status changed to WontFix.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.2
Development

No branches or pull requests
5 participants
@davecheney @agl @rsc @robpike @gopherbot