x/tools/gopls: out of bounds panic in template completion #49600
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
|
Thanks for the report, and details. CC @pjweinb. |
|
Transfering to the Go issue tracker, since this is really a gopls bug. |
findleyr
changed the title
gopherbot
added
Tools
findleyr
added
the
NeedsInvestigation
|
thank you for the report. |
|
i can reproduce the error and have found the cause. (That's the better news. Still have to figure out how to fix it (and why the tests didn't find this problem.) |
|
Change https://golang.org/cl/366036 mentions this issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
gopls version: v0.7.3
gopls flags: -rpc.trace
update flags: proxy
extension version: 2021.11.602
go version: 1.17.3
environment: VSCodium linux
initialization error: undefined
issue timestamp: Mon, 15 Nov 2021 13:01:52 GMT
restart history:
Mon, 15 Nov 2021 11:56:01 GMT: activation (enabled: true)
ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.
Describe what you observed.
I was editing a
.tmplfile, when the crash happend. To be more specific:My cursor was at the
tof the last/new_comment(I was just typing that part) when the crash happens.panic: runtime error: slice bounds out of range [5880:5878] goroutine 166 [running]: golang.org/x/tools/internal/lsp/template.(*completer).complete(0xc0079b2fb8) completion.go:117 0xd85 golang.org/x/tools/internal/lsp/template.Completion({0xc0123794a0, 0xc005de8588}, {0xf9ddc0, 0xc000a0bc00}, {0xf8a850, 0xc015aa2960}, {0x14daf328, 0xc0}, {0x3ff0000000000000, {0x0, ...}}) completion.go:58 0x328 golang.org/x/tools/internal/lsp.(*Server).completion(0xc001ecebf8, {0xf74bb8, 0xc000380f00}, 0xc00a433220) completion.go:37 0x17c golang.org/x/tools/internal/lsp.(*Server).Completion(0xc000544000, {0xf74bb8, 0xc000380f00}, 0xc00a00) server_gen.go:32 0x25 golang.org/x/tools/internal/lsp/protocol.serverDispatch({0xf74bb8, 0xc000380f00}, {0xfa2160, 0xc0003e7560}, 0xc0158caf60, {0xf74e20, 0xc000380e80}) tsserver.go:382 0x18dd golang.org/x/tools/internal/lsp/protocol.ServerHandler.func1({0xf74bb8, 0xc000380f00}, 0xc0158caf60, {0xf74e20, 0xc000380e80}) protocol.go:154 0x90 golang.org/x/tools/internal/lsp/lsprpc.handshaker.func1({0xf74bb8, 0xc000380f00}, 0xc0158caf60, {0xf74e20, 0xc000380e80}) lsprpc.go:506 0xa7d golang.org/x/tools/internal/jsonrpc2.MustReplyHandler.func1({0xf74bb8, 0xc000380f00}, 0xc0004b8690, {0xf74e20, 0xc000380e80}) handler.go:35 0xf6 golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1.2() handler.go:103 0xa3 created by golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1 handler.go:100 0x20f [Error - 2:01:37 PM]The text was updated successfully, but these errors were encountered: