Skip to content

x/tools/gopls: multiline strings should be foldable in the editor #49554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matskiv opened this issue Nov 11, 2021 · 5 comments
Closed

x/tools/gopls: multiline strings should be foldable in the editor #49554

matskiv opened this issue Nov 11, 2021 · 5 comments
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.7.5

Comments

@matskiv
Copy link

matskiv commented Nov 11, 2021

Is your feature request related to a problem? Please describe.
Some multiline strings needlessly take up space in the editor and it is not possible to fold them into a single line.

Describe the solution you'd like
Every multiline string should become a foldable region.

Describe alternatives you've considered
I quickly checked available extensions, but there doesn't seem to be one for this exact use case.

Additional context
Screenshot from 2021-11-11 10-33-24
@hyangah hyangah changed the title Multiline strings should be foldable in the editor x/tools/gopls: multiline strings should be foldable in the editor Nov 12, 2021
@hyangah hyangah transferred this issue from golang/vscode-go Nov 12, 2021
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 12, 2021
@gopherbot gopherbot added this to the Unreleased milestone Nov 12, 2021
@findleyr
Copy link
Member

This is a good suggestion, and I think it's a good candidate for external contribution.

Marking as help-wanted, though @ansaba might be interested in taking this.

@findleyr findleyr modified the milestones: Unreleased, gopls/unplanned Nov 16, 2021
@findleyr findleyr added help wanted FeatureRequest Issues asking for a new feature that does not need a proposal. labels Nov 16, 2021
@natescode
Copy link

I'd like to try to take this one on. It'd be my first contribution (already followed the contribution guide).

What's my next step?

@hyangah
Copy link
Contributor

hyangah commented Nov 23, 2021

The relevant code place is https://go.googlesource.com/tools/+/refs/heads/master/internal/lsp/source/folding_range.go

For tests, modifying the existing source_test.go and add test data for the new case here will be sufficient.

And, please check the instruction for gopls contributors.

cc @suzmue @findleyr

rhnvrm added a commit to rhnvrm/tools that referenced this issue Dec 7, 2021
@rhnvrm
x/tools/gopls: foldable multiline strings
33028eb 
This commit adds support for detecting multiline strings for folding
ranges.

Ref: golang/go#49554
@rhnvrm rhnvrm mentioned this issue Dec 7, 2021
Closed
@rhnvrm
Copy link
Contributor

rhnvrm commented Dec 7, 2021

Hey

I worked on implementing this at golang/tools#354

Peek 2021-12-07 13-35

rhnvrm added a commit to rhnvrm/tools that referenced this issue Dec 15, 2021
@rhnvrm
x/tools/gopls: foldable multiline strings
a615703 
This commit adds support for detecting multiline strings for folding
ranges.

Fixes golang/go#49554
rhnvrm added a commit to rhnvrm/tools that referenced this issue Dec 22, 2021
@rhnvrm
internal/lsp: foldable multiline strings
ebcb3f0 
This commit adds support for detecting multiline strings for folding
ranges.

Fixes golang/go#49554
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/372414 mentions this issue: internal/lsp: foldable multiline strings

rhnvrm added a commit to rhnvrm/tools that referenced this issue Dec 22, 2021
@rhnvrm
internal/lsp: foldable multiline strings
3894380 
This commit adds support for detecting multiline strings for folding
ranges.

Fixes golang/go#49554
@golang golang locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.7.5
Development

Successfully merging a pull request may close this issue.

internal/lsp: foldable multiline strings rhnvrm/tools
6 participants
@rhnvrm @matskiv @hyangah @gopherbot @natescode @findleyr