Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp/lsprpc: TestEnvForwarding failures with "context deadline exceeded" #49503

Closed
bcmills opened this issue Nov 10, 2021 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 10, 2021

Something in lsprpc.TestEnvForwarding appears to have a 5s timeout, which may be too short for some builders.

(CC @findleyr, but this can probably wait a week or two.)

greplogs --dashboard -md -l -e '(?m)FAIL: TestEnvForwarding.*\n\s+.*context deadline exceeded'

2021-11-10T05:08:25-e900012-17980df/openbsd-386-68
2021-11-10T00:45:37-e900012-ec86bb5/openbsd-386-68
2021-11-09T21:26:25-e900012-b93220c/openbsd-386-68
2021-11-09T20:10:50-e900012-5430203/openbsd-386-68
2021-11-09T18:23:16-e900012-55e6e82/openbsd-386-68
2021-11-09T18:03:59-e900012-36dbf7f/openbsd-386-68
2021-11-09T16:49:01-e900012-3729a67/openbsd-386-68
2021-11-08T20:46:37-c8e8de6-23991f5/openbsd-386-68
2021-11-05T23:32:57-b8b8e7f-f58c78a/openbsd-386-68
2021-11-04T19:43:35-6f75aad-5af93a2/openbsd-386-68
2021-11-04T19:34:33-84e69e7-5af93a2/openbsd-386-68
2021-11-04T18:22:03-84e69e7-b2149ac/openbsd-386-68
2021-11-04T16:36:19-84e69e7-f934b83/openbsd-386-68
2021-11-04T14:17:18-84e69e7-901bf29/openbsd-386-68
2021-11-03T21:45:33-84e69e7-d3f5dd5/openbsd-386-68
2021-11-03T20:51:16-84e69e7-b212ba6/openbsd-386-68
2021-11-03T00:07:38-714668c-49a0063/openbsd-386-68
2021-11-02T21:21:51-9aacde2-631b567/openbsd-386-68
2021-11-02T20:49:06-6561d8c-b246873/openbsd-386-68
2021-11-02T20:49:06-6561d8c-631b567/openbsd-386-68
2021-11-02T18:22:55-bb4add0-629ffeb/openbsd-386-68
2021-10-31T15:36:50-351c04c-243c5ae/solaris-amd64-oraclerel
2021-10-30T00:47:26-a6c6f4b-d19c5bd/openbsd-386-68
2021-10-28T20:50:34-e7eb6f6-d0751b1/openbsd-386-68
2021-10-28T15:31:34-8de2a7f-8c9c148/openbsd-386-68
2021-10-26T20:41:32-9626607-3a0cd11/openbsd-386-68
2021-10-26T18:33:39-244f92e-c580180/openbsd-386-68
2021-10-23T12:53:38-affba50-2ac3bdf/netbsd-arm-bsiegert
2021-10-17T02:23:16-98f6e03-fa7d11a/netbsd-arm-bsiegert
2021-10-15T16:00:01-98f6e03-fad4a16/netbsd-arm-bsiegert
2021-10-13T04:56:02-378b9e1-e8f99da/netbsd-arm-bsiegert
2021-10-12T22:26:24-074820e-2ac3bdf/freebsd-amd64-race
2021-10-10T13:37:52-1af23bd-c580180/netbsd-arm-bsiegert
2021-10-01T19:30:53-13c407c-7d57324/netbsd-arm-bsiegert
2021-10-01T04:28:36-e89823e-7d57324/netbsd-arm-bsiegert
2021-09-21T02:24:06-91c880c-552410f/netbsd-arm-bsiegert
2021-08-17T02:54:26-6932d22-ec51703/netbsd-arm-bsiegert
2021-08-07T01:29:22-d529aec-891547e/netbsd-arm-bsiegert
2021-08-04T21:03:22-f367f01-fa6aa87/netbsd-arm-bsiegert
2021-08-03T17:18:10-7a2ec09-7921829/solaris-amd64-oraclerel
2021-08-03T16:06:16-594b3a2-16ab7e4/solaris-amd64-oraclerel
2021-06-08T12:17:50-716319f-2169deb/netbsd-arm-bsiegert
2021-04-29T04:18:39-800adbe-d099475/linux-amd64-wsl

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 10, 2021
@gopherbot gopherbot added this to the Unreleased milestone Nov 10, 2021
@hyangah hyangah added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 10, 2021
@hyangah hyangah modified the milestones: Unreleased, gopls/unplanned Nov 10, 2021
@gopherbot
Copy link

Change https://golang.org/cl/362976 mentions this issue: internal/lsp/lsprpc: increase timeout for TestEnvForwarding

gopherbot pushed a commit to golang/tools that referenced this issue Nov 11, 2021
Some slow builders need more time to get ready.

Updates golang/go#49503

Change-Id: I9225ef43b1fdeb5195467331c7b779fb11dd0e7e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/362976
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
@hyangah
Copy link
Contributor

hyangah commented Nov 12, 2021

I am closing this. @bcmills please reopen this if you still see failures.

@hyangah hyangah closed this as completed Nov 12, 2021
@golang golang locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants