Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: basepin vm snapshot lists break with too many disks #49483

Closed
toothrot opened this issue Nov 9, 2021 · 2 comments
Closed

x/build/cmd/coordinator: basepin vm snapshot lists break with too many disks #49483

toothrot opened this issue Nov 9, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release Team
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

toothrot commented Nov 9, 2021

It happened to work before, but we have gone over 500 disks in some of our zones, which is the default page list.

# "basepin" status: VM snapshots
# Notes: https://golang.org/issue/21305
Error: too many disks in us-central1-c; pagination not supported (yet?)

We could either paginate, or filter down to basepin disks, which should always be much fewer than 500
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 9, 2021
@toothrot toothrot added this to the Unreleased milestone Nov 9, 2021
@toothrot toothrot self-assigned this Nov 9, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 9, 2021
@gopherbot
Copy link

Change https://golang.org/cl/362539 mentions this issue: internal/buildgo: handle greater quantity of disks

gopherbot pushed a commit to golang/build that referenced this issue Nov 9, 2021
@toothrot
internal/buildgo: handle greater quantity of disks
1e70b36 
After creating some new resources in our project, we have gone over 500
disks in some zones, which is the default pagination size. This change
filters to just the disks we care about, which should remain at well
under 500 for the foreseeable future.

For golang/go#49483

Change-Id: I4c5c4698624453fe51373a5668cc0a40b4813dbc
Reviewed-on: https://go-review.googlesource.com/c/build/+/362539
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@cagedmantis cagedmantis added this to In Progress in Go Release Team Nov 9, 2021
@toothrot
Copy link
Contributor Author

toothrot commented Nov 9, 2021

A filter seems to work for now

@toothrot toothrot closed this as completed Nov 9, 2021
Go Release Team automation moved this from In Progress to Done Nov 9, 2021
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@toothrot @gopherbot