Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509/internal/macos: build fails on macOS #49435

Closed
lufia opened this issue Nov 8, 2021 · 5 comments
Closed

crypto/x509/internal/macos: build fails on macOS #49435

lufia opened this issue Nov 8, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.18

Comments

@lufia
Copy link
Contributor

lufia commented Nov 8, 2021 •
edited

What version of Go are you using (go version)?

$ go version
go version devel go1.18-9e6ad46bcc Sun Nov 7 04:57:22 2021 +0000 darwin/amd64

Does this issue reproduce with the latest release?

Yes (I checked reproduced at 9e6ad46)

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/lufia/Library/Caches/go-build"
GOENV="/Users/lufia/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/lufia/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/lufia"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/lufia/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/lufia/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17.3"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Volumes/gotest/go/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/0b/8y9l7z3x1pv4p2c5l9f0y6600000gn/T/go-build3778853785=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

% ./all.bash

What did you expect to see?

I expect all tests are passed.

What did you see instead?

% ./all.bash             
Building Go cmd/dist using /Users/lufia/go1.11. (go1.11.2 darwin/amd64)
Building Go toolchain1 using /Users/lufia/go1.11.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for darwin/amd64.

##### Testing packages.
ok  	archive/tar	0.431s
ok  	archive/zip	0.629s
ok  	bufio	0.398s
ok  	bytes	0.701s
ok  	compress/bzip2	0.307s
ok  	compress/flate	1.093s
ok  	compress/gzip	0.728s
ok  	compress/lzw	0.349s
ok  	compress/zlib	0.929s
ok  	constraints	1.188s
ok  	container/heap	0.655s
ok  	container/list	0.784s
ok  	container/ring	0.782s
ok  	context	0.338s
ok  	crypto	0.324s
ok  	crypto/aes	0.377s
ok  	crypto/cipher	0.601s
ok  	crypto/des	0.349s
ok  	crypto/dsa	0.380s
ok  	crypto/ecdsa	0.369s
ok  	crypto/ed25519	0.343s
ok  	crypto/ed25519/internal/edwards25519	12.541s
ok  	crypto/ed25519/internal/edwards25519/field	4.021s
ok  	crypto/elliptic	0.488s
ok  	crypto/elliptic/internal/fiat	0.372s [no tests to run]
ok  	crypto/elliptic/internal/nistec	2.224s
ok  	crypto/hmac	0.282s
ok  	crypto/internal/subtle	0.379s
ok  	crypto/md5	0.288s
ok  	crypto/rand	0.310s
ok  	crypto/rc4	0.488s
ok  	crypto/rsa	0.399s
ok  	crypto/sha1	0.299s
ok  	crypto/sha256	0.367s
ok  	crypto/sha512	0.454s
ok  	crypto/subtle	0.381s
ok  	crypto/tls	1.177s
ok  	crypto/x509	1.020s
ok  	database/sql	0.923s
ok  	database/sql/driver	0.253s
ok  	debug/buildinfo	0.280s
ok  	debug/dwarf	0.913s
ok  	debug/elf	0.390s
ok  	debug/gosym	0.616s
ok  	debug/macho	0.341s
ok  	debug/pe	0.669s
ok  	debug/plan9obj	0.329s
ok  	embed	0.840s [no tests to run]
ok  	embed/internal/embedtest	0.788s
ok  	encoding/ascii85	0.571s
ok  	encoding/asn1	0.311s
ok  	encoding/base32	0.294s
ok  	encoding/base64	0.335s
ok  	encoding/binary	0.290s
ok  	encoding/csv	0.296s
ok  	encoding/gob	0.394s
ok  	encoding/hex	0.545s
ok  	encoding/json	1.271s
ok  	encoding/pem	0.339s
ok  	encoding/xml	0.566s
ok  	errors	0.745s
ok  	expvar	0.728s
ok  	flag	0.326s
ok  	fmt	0.457s
ok  	go/ast	0.426s
ok  	go/build	3.787s
ok  	go/build/constraint	0.602s
ok  	go/constant	0.535s
ok  	go/doc	0.438s
ok  	go/format	0.645s
ok  	go/importer	0.595s
ok  	go/internal/gccgoimporter	0.349s
ok  	go/internal/gcimporter	9.248s
ok  	go/internal/srcimporter	14.915s
ok  	go/parser	0.408s
ok  	go/printer	0.720s
ok  	go/scanner	0.308s
ok  	go/token	0.380s
ok  	go/types	6.252s
ok  	hash	0.269s
ok  	hash/adler32	0.333s
ok  	hash/crc32	0.261s
ok  	hash/crc64	0.297s
ok  	hash/fnv	0.321s
ok  	hash/maphash	0.449s
ok  	html	0.255s
ok  	html/template	0.463s
ok  	image	0.404s
ok  	image/color	0.341s
ok  	image/draw	0.420s
ok  	image/gif	0.553s
ok  	image/jpeg	0.757s
ok  	image/png	0.297s
ok  	index/suffixarray	0.512s
ok  	internal/abi	0.445s
ok  	internal/buildcfg	0.303s
ok  	internal/cpu	0.301s
ok  	internal/execabs	0.279s
ok  	internal/fmtsort	0.248s
ok  	internal/fuzz	0.413s
ok  	internal/godebug	0.241s
ok  	internal/intern	1.204s
ok  	internal/itoa	0.331s
ok  	internal/poll	0.310s
ok  	internal/profile	0.263s
ok  	internal/reflectlite	0.822s
ok  	internal/singleflight	0.283s
ok  	internal/trace	0.383s
ok  	internal/unsafeheader	0.378s
ok  	internal/xcoff	0.879s
ok  	io	0.319s
ok  	io/fs	0.360s
ok  	io/ioutil	0.301s
ok  	log	0.264s
ok  	log/syslog	1.514s
ok  	math	0.367s
ok  	math/big	3.034s
ok  	math/bits	0.743s
ok  	math/cmplx	0.313s
ok  	math/rand	0.720s
ok  	mime	0.405s
ok  	mime/multipart	0.825s
ok  	mime/quotedprintable	0.540s
ok  	net	2.704s
ok  	net/http	15.566s
ok  	net/http/cgi	1.120s
ok  	net/http/cookiejar	0.693s
ok  	net/http/fcgi	0.391s
ok  	net/http/httptest	0.418s
ok  	net/http/httptrace	0.346s
ok  	net/http/httputil	0.963s
ok  	net/http/internal	0.254s
ok  	net/http/internal/ascii	0.318s
ok  	net/http/pprof	5.492s
ok  	net/internal/socktest	0.246s
ok  	net/mail	0.342s
ok  	net/netip	1.371s
ok  	net/rpc	0.449s
ok  	net/rpc/jsonrpc	0.327s
ok  	net/smtp	0.425s
ok  	net/textproto	0.261s
ok  	net/url	0.428s
ok  	os	3.729s
ok  	os/exec	2.473s
ok  	os/signal	2.565s
ok  	os/user	0.326s
ok  	path	0.297s
ok  	path/filepath	0.646s
ok  	plugin	0.339s
ok  	reflect	0.582s
ok  	regexp	0.414s
ok  	regexp/syntax	1.005s
ok  	runtime	142.146s
ok  	runtime/cgo	0.512s
ok  	runtime/debug	0.407s
ok  	runtime/internal/atomic	0.402s
ok  	runtime/internal/math	0.278s
ok  	runtime/internal/sys	0.520s
ok  	runtime/metrics	0.686s
ok  	runtime/pprof	11.066s
ok  	runtime/trace	2.488s
ok  	sort	0.622s
ok  	strconv	2.051s
ok  	strings	0.557s
ok  	sync	0.693s
ok  	sync/atomic	2.993s
ok  	syscall	0.811s
ok  	testing	1.455s
ok  	testing/fstest	0.288s
ok  	testing/iotest	0.495s
ok  	testing/quick	0.309s
ok  	text/scanner	0.280s
ok  	text/tabwriter	0.334s
ok  	text/template	0.679s
ok  	text/template/parse	0.366s
ok  	time	2.887s
ok  	unicode	0.421s
ok  	unicode/utf16	0.430s
ok  	unicode/utf8	0.335s
ok  	cmd/addr2line	4.854s
ok  	cmd/api	22.916s
ok  	cmd/asm/internal/asm	2.998s
ok  	cmd/asm/internal/lex	0.471s
ok  	cmd/compile/internal/amd64	8.269s
ok  	cmd/compile/internal/dwarfgen	0.791s
ok  	cmd/compile/internal/importer	1.340s
ok  	cmd/compile/internal/ir	0.314s
ok  	cmd/compile/internal/logopt	0.895s
ok  	cmd/compile/internal/noder	0.456s
ok  	cmd/compile/internal/ssa	44.824s
ok  	cmd/compile/internal/syntax	0.452s
ok  	cmd/compile/internal/test	21.154s
ok  	cmd/compile/internal/typecheck	1.353s
ok  	cmd/compile/internal/types	0.293s
ok  	cmd/compile/internal/types2	2.616s
ok  	cmd/cover	4.728s
ok  	cmd/doc	0.638s
ok  	cmd/fix	6.117s
ok  	cmd/go	192.346s
ok  	cmd/go/internal/auth	0.372s
ok  	cmd/go/internal/cache	0.881s
ok  	cmd/go/internal/fsys	0.411s
ok  	cmd/go/internal/generate	0.719s
ok  	cmd/go/internal/get	0.780s
ok  	cmd/go/internal/imports	0.477s
ok  	cmd/go/internal/load	0.546s
ok  	cmd/go/internal/lockedfile	0.521s
ok  	cmd/go/internal/lockedfile/internal/filelock	0.491s
ok  	cmd/go/internal/modconv	0.424s
ok  	cmd/go/internal/modfetch	0.476s
ok  	cmd/go/internal/modfetch/codehost	0.417s
ok  	cmd/go/internal/modfetch/zip_sum_test	0.575s
ok  	cmd/go/internal/modload	0.543s
ok  	cmd/go/internal/mvs	0.342s
ok  	cmd/go/internal/par	0.664s
ok  	cmd/go/internal/search	0.981s
ok  	cmd/go/internal/str	0.719s
ok  	cmd/go/internal/test	0.792s
ok  	cmd/go/internal/vcs	0.714s
ok  	cmd/go/internal/web	0.468s
ok  	cmd/go/internal/work	0.660s
ok  	cmd/gofmt	0.400s
ok  	cmd/internal/archive	3.038s
ok  	cmd/internal/buildid	1.205s
ok  	cmd/internal/dwarf	0.365s
ok  	cmd/internal/edit	0.404s
ok  	cmd/internal/goobj	0.268s
ok  	cmd/internal/moddeps	9.379s
ok  	cmd/internal/obj	0.735s
ok  	cmd/internal/obj/ppc64	0.788s
ok  	cmd/internal/obj/riscv	0.562s
ok  	cmd/internal/obj/s390x	0.549s
ok  	cmd/internal/obj/x86	34.016s
ok  	cmd/internal/objabi	0.641s
ok  	cmd/internal/pkgpath	0.403s
ok  	cmd/internal/quoted	0.752s
ok  	cmd/internal/src	0.349s
ok  	cmd/internal/sys	0.394s
ok  	cmd/internal/test2json	0.576s
ok  	cmd/link	40.192s
ok  	cmd/link/internal/benchmark	0.834s
ok  	cmd/link/internal/ld	41.836s
ok  	cmd/link/internal/loader	0.352s
ok  	cmd/nm	10.996s
ok  	cmd/objdump	19.453s
ok  	cmd/pack	16.617s
ok  	cmd/pprof	15.161s
ok  	cmd/trace	0.761s
ok  	cmd/vet	22.550s

##### os/user with tag osusergo
ok  	os/user	0.318s

##### GOOS=ios on darwin/amd64
package crypto/x509
	imports crypto/x509/internal/macos: build constraints exclude all Go files in /Volumes/gotest/go/src/crypto/x509/internal/macos
2021/11/08 17:27:27 Failed: exit status 1

##### GOMAXPROCS=2 runtime -cpu=1,2,4 -quick
ok  	runtime	7.330s

##### Testing without libgcc.
ok  	net	0.347s
ok  	os/user	0.322s

##### internal linking of -buildmode=pie
skipped due to earlier error
skipped due to earlier error

##### sync -cpu=10
skipped due to earlier error

##### Testing race detector
skipped due to earlier error
skipped due to earlier error
skipped due to earlier error
go tool dist: FAILED
@lufia lufia mentioned this issue Nov 8, 2021
Closed
@ALTree
Copy link
Member

ALTree commented Nov 8, 2021

Mmh, are you reporting that this affects go1.17? Because looking at https://build.golang.org it should only affect tips, the issue started 2 days ago.

@lufia
Copy link
Contributor Author

lufia commented Nov 8, 2021

I see, I had been misunderstood meaning of What version of Go are you using question. I've edited above description.

@ALTree ALTree added this to the Go1.18 milestone Nov 8, 2021
@ALTree ALTree added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 8, 2021
@ALTree
Copy link
Member

ALTree commented Nov 8, 2021

Okay, thanks. So you're reporting the recent builders breakage.

@bcmills bcmills added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Nov 8, 2021
@gopherbot
Copy link

Change https://golang.org/cl/362242 mentions this issue: Revert "crypto/x509: use the platform verifier on iOS"

@gopherbot
Copy link

Change https://golang.org/cl/362294 mentions this issue: crypto/x509: remove ios build tag restriction

@golang golang locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@lufia @ALTree @bcmills @gopherbot