Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: Expand calls interface data problem [1.17 backport] #49392

Closed
gopherbot opened this issue Nov 5, 2021 · 6 comments
Closed

cmd/compile: internal compiler error: Expand calls interface data problem [1.17 backport] #49392

gopherbot opened this issue Nov 5, 2021 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.4

Comments

@gopherbot
Copy link

@cuonglm requested issue #49378 to be considered for backport to the next 1.17 minor release.

@gopherbot please open backport to 1.16 and 1.17

cc @randall77 @dr2chase
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 5, 2021
@gopherbot gopherbot mentioned this issue Nov 5, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.4 milestone Nov 5, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/361596 mentions this issue: [release-branch.go1.17] cmd/compile: only update source type when processing struct/array

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Nov 24, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 24, 2021
@heschi
Copy link
Contributor

heschi commented Nov 24, 2021

@randall77 @dr2chase This cherrypick's CL still needs review.

@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Ping. I plan to cut the minor releases tomorrow.

@mknyszek
Copy link
Contributor

mknyszek commented Dec 1, 2021

Update: I'm considering it, it's not set in stone yet. :)

@cuonglm
Copy link
Member

cuonglm commented Dec 2, 2021

@heschi @mknyszek Actually, both the CLs are reviewed. I think they just need someone in @golang/release team to submit.

@gopherbot
Copy link
Author

Closed by merging 759a921 to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Dec 2, 2021
@cuonglm @mknyszek
[release-branch.go1.17] cmd/compile: only update source type when pro…
759a921 
…cessing struct/array

This is backport of CL 3651594, with the test from CL 360057.

CL 360057 fixed missing update source type in storeArgOrLoad. However,
we should only update the type when processing struct/array. If we
update the type right before calling storeArgOrLoad, we may generate a
value with invalid type, e.g, OpStructSelect with non-struct type.

Fixes #49392

Change-Id: Ib7e10f72f818880f550aae5c9f653db463ce29b0
Reviewed-on: https://go-review.googlesource.com/c/go/+/361594
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/361596
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
@golang golang locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.4
Development

No branches or pull requests
4 participants
@mknyszek @cuonglm @gopherbot @heschi