Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: new UDP allocs test breaks on Plan 9 #49376

Closed
millerresearch opened this issue Nov 5, 2021 · 2 comments
Closed

net: new UDP allocs test breaks on Plan 9 #49376

millerresearch opened this issue Nov 5, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@millerresearch
Copy link
Contributor

millerresearch commented Nov 5, 2021 •
edited

CL 361396 added TestAllocs in udpsock_test.go which fails with message "not supported by plan 9".

The test uses function (*UDPConn).writeMsgAddrPort which indeed is not supported on Plan 9 (perhaps someone else knows why not?).

A number of other tests in this file are skipped when running on Plan 9. It appears this one should be skipped too.
@mvdan
Copy link
Member

mvdan commented Nov 5, 2021

cc @josharian

@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 5, 2021
@josharian
Copy link
Contributor

Fixed by CL 361634.

@golang golang locked and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@josharian @mvdan @gopherbot @thanm @millerresearch