Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/netip: zero value of Addr is undocumented #49364

Closed
FiloSottile opened this issue Nov 4, 2021 · 2 comments
Closed

net/netip: zero value of Addr is undocumented #49364

FiloSottile opened this issue Nov 4, 2021 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.18

Comments

@FiloSottile
Copy link
Contributor

The zero value of Addr is not documented (is it 0.0.0.0? is it invalid?) but is referred to in some docs.

If slice's length is not 4 or 16, AddrFromSlice returns Addr{}, false.
@FiloSottile FiloSottile added this to the Go1.18 milestone Nov 4, 2021
@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Nov 4, 2021
@ianlancetaylor
Copy link
Contributor

CC @bradfitz @josharian

@gopherbot
Copy link

Change https://golang.org/cl/361914 mentions this issue: net/netip: document the zero Addr

@golang golang locked and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@FiloSottile @ianlancetaylor @gopherbot