x/oauth2/google/internal/externalaccount: frequent failures in AWS credential tests #49339
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
bcmills
added
the
NeedsInvestigation
|
@codyoss, I can't really even tell what's going wrong in these tests — the logs don't seem to indicate the nature of the problem. Could you take a look? |
|
I will take a peek. |
|
Change https://golang.org/cl/361354 mentions this issue: |
codegod2222
added a commit
to codegod2222/oauth_go
that referenced
this issue
Nov 25, 2022
It seems like these handful of test would fail because of issues related to timings. When running the tests there was sometimes a second scew from when the subjectToken got and want were calculated. Switched them all to use a static clock so the time portion will never differ. Fixes golang/go#49339 Change-Id: Ia2e4e140526ee1fc37fa9d24765cd8ec3033ea22 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/361354 Trust: Cody Oss <codyoss@google.com> Run-TryBot: Cody Oss <codyoss@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
nikolay-turpitko
pushed a commit
to nikolay-turpitko/oauth2
that referenced
this issue
Jan 17, 2023
It seems like these handful of test would fail because of issues related to timings. When running the tests there was sometimes a second scew from when the subjectToken got and want were calculated. Switched them all to use a static clock so the time portion will never differ. Fixes golang/go#49339 Change-Id: Ia2e4e140526ee1fc37fa9d24765cd8ec3033ea22 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/361354 Trust: Cody Oss <codyoss@google.com> Run-TryBot: Cody Oss <codyoss@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
greplogs --dashboard -md -l -e '--- FAIL: TestAwsCredential'2021-11-03T09:23:34-ba495a6-6458b2e/android-amd64-emu
2021-11-03T00:49:50-ba495a6-a4b2c57/freebsd-amd64-race
2021-11-02T23:05:17-ba495a6-eb63cbd/linux-amd64-race
2021-11-02T17:31:50-ba495a6-4e7dd9f/linux-386-clang
2021-11-02T06:19:33-ba495a6-4633b2d/freebsd-amd64-race
2021-10-27T20:42:29-6b3c2da-644555d/windows-arm64-10
2021-10-26T01:18:46-6b3c2da-49fda9e/windows-amd64-race
2021-10-25T16:07:11-6b3c2da-c6e82e5/windows-amd64-2016
2021-10-22T14:05:31-6b3c2da-ff8115d/windows-arm64-10
2021-10-15T18:07:49-6b3c2da-8331f25/linux-ppc64le-buildlet
2021-10-14T17:38:39-6b3c2da-011fd00/freebsd-386-12_2
2021-10-11T19:15:23-6b3c2da-52078fa/windows-arm64-10
2021-10-07T18:11:41-6b3c2da-2ac3bdf/solaris-amd64-oraclerel
2021-10-05T17:10:45-2bc19b1-5140ad1/linux-ppc64-buildlet
2021-10-05T00:29:40-2bc19b1-81b7ec1/windows-amd64-longtest
2021-10-04T22:46:23-2bc19b1-17674e2/linux-arm64-packet
2021-08-04T16:42:14-a41e5a7-e90f402/linux-ppc64-buildlet
2021-05-14T00:56:52-81ed05c-12d383c/js-wasm
2021-04-27T02:39:52-5e61552-434e12f/linux-amd64-race
2021-04-12T18:32:27-2e8d934-07b2fee/linux-amd64-jessie
2021-04-02T13:30:18-22b0ada-b165085/openbsd-amd64-68
2021-03-22T19:09:53-cd4f82c-a93849b/dragonfly-amd64
2021-03-10T21:25:35-9bb9049-6e04188/aix-ppc64
2021-02-18T20:24:05-ba52d33-1a7e9af/openbsd-amd64-64
2021-02-16T17:42:55-6667018-098504c/linux-arm
2021-02-11T01:10:35-6667018-930c2c9/openbsd-386-64
2021-02-10T19:26:28-6667018-e9c9683/openbsd-386-64
2021-02-09T05:28:50-0101308-e0ac989/windows-arm-zx2c4
2021-02-09T01:22:45-0101308-cea4e21/plan9-arm
2021-02-08T23:32:14-0101308-dc725bf/openbsd-amd64-64
2021-02-04T20:43:04-0101308-5cf057d/windows-arm-zx2c4
2021-02-04T14:27:49-0101308-6a64f5f/android-amd64-emu
2021-02-04T14:27:44-0101308-c3e1c38/openbsd-amd64-62
2021-02-02T22:36:08-0101308-58dc445/openbsd-amd64-62
The text was updated successfully, but these errors were encountered: