Skip to content

x/pkgsite: package docs missing for packages that use "//go:build" without "// +build" #49229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Oct 29, 2021 · 2 comments
Closed

x/pkgsite: package docs missing for packages that use "//go:build" without "// +build" #49229

bcmills opened this issue Oct 29, 2021 · 2 comments
Labels
FrozenDueToAge okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 pkgsite release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 29, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/testing@master

What is your user agent?

Mozilla/5.0 (X11; CrOS x86_64 14150.64.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.104 Safari/537.36

Screenshot

image

What did you do?

Load docs for the testing package after CL 344955

What did you expect to see?

Docs for the testing package.

What did you see instead?

Only a listing of subdirectories.
@gopherbot gopherbot added this to the Unreleased milestone Oct 29, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Oct 29, 2021

This seems like a release-blocker for Go 1.18: I don't see how we can release this version of the standard library if pkg.go.dev can't display its documentation.

@bcmills bcmills added release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Oct 29, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.18 Oct 29, 2021
@jba jba self-assigned this Oct 29, 2021
This was referenced Oct 29, 2021
Closed
Closed
@zikaeroh zikaeroh mentioned this issue Nov 2, 2021
Closed
@kevinburke kevinburke mentioned this issue Nov 2, 2021
Closed
@dmitshur dmitshur added the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Nov 3, 2021
@seankhliao seankhliao mentioned this issue Nov 5, 2021
Closed
@dmitshur dmitshur mentioned this issue Nov 5, 2021
Closed
@ALTree ALTree mentioned this issue Nov 8, 2021
Closed
@jba
Copy link
Contributor

jba commented Nov 10, 2021

This is fixed and deployed for the stdlib at the current tip. Since the problem was in our preprocessing stage, other modules might need to be reprocessed. I've already reprocessed github.com/anacrolix/torrent@v1.34.0 and github.com/bcmills/more@main. If your module is still affected, comment here.

@jba jba closed this as completed Nov 10, 2021
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 pkgsite release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @jba