Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/windows: checkptr failure in TestNtCreateFileAndNtSetInformationFile starting 2021-10-23 #49217

Closed
bcmills opened this issue Oct 29, 2021 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 29, 2021

greplogs --dashboard -md -l -e \(\?ms\)checkptr.\*TestNtCreateFileAndNtSetInformationFile

2021-10-28T22:38:00-69cdffd-af05d8b/windows-amd64-race
2021-10-28T21:17:17-69cdffd-f6f024f/windows-amd64-race
2021-10-28T20:50:34-69cdffd-d0751b1/windows-amd64-race
2021-10-28T20:43:39-69cdffd-b954024/windows-amd64-race
2021-10-28T18:17:57-69cdffd-f229e70/windows-amd64-race
2021-10-28T18:01:38-69cdffd-9004433/windows-amd64-race
2021-10-28T18:01:34-69cdffd-18b9702/windows-amd64-race
2021-10-28T16:54:58-69cdffd-6bd0e7f/windows-amd64-race
2021-10-28T16:34:40-69cdffd-91aa2f1/windows-amd64-race
2021-10-28T16:08:36-69cdffd-6f0185b/windows-amd64-race
2021-10-28T15:35:25-69cdffd-278b9b3/windows-amd64-race
2021-10-28T15:31:34-69cdffd-8c9c148/windows-amd64-race
2021-10-28T15:31:28-69cdffd-8bdb0b2/windows-amd64-race
2021-10-28T15:08:31-69cdffd-5c98bcb/windows-amd64-race
2021-10-28T14:25:03-69cdffd-a3bb28e/windows-amd64-race
2021-10-28T03:44:12-69cdffd-2ff1074/windows-amd64-race
2021-10-28T03:35:34-69cdffd-b8f928b/windows-amd64-race
2021-10-28T02:35:22-69cdffd-056dfe6/windows-amd64-race
2021-10-28T01:15:26-69cdffd-b2fe2eb/windows-amd64-race
2021-10-28T01:03:38-69cdffd-12dc48f/windows-amd64-race
2021-10-28T00:11:24-69cdffd-a91d0b6/windows-amd64-race
2021-10-27T19:34:49-69cdffd-ffd2284/windows-amd64-race
2021-10-27T19:18:20-69cdffd-514ebae/windows-amd64-race
2021-10-27T18:24:50-69cdffd-259735f/windows-amd64-race
2021-10-27T18:08:49-69cdffd-bb49eb3/windows-amd64-race
2021-10-27T16:59:43-69cdffd-c0ac39c/windows-amd64-race
2021-10-27T16:39:27-69cdffd-4f73fd0/windows-amd64-race
2021-10-27T13:12:49-69cdffd-cfb5321/windows-amd64-race
2021-10-27T08:50:27-69cdffd-bdefb77/windows-amd64-race
2021-10-27T06:23:35-69cdffd-5786a54/windows-amd64-race
2021-10-27T05:33:58-69cdffd-ca5f65d/windows-amd64-race
2021-10-26T23:12:17-69cdffd-13eccaa/windows-amd64-race
2021-10-26T22:05:53-69cdffd-80be4a4/windows-amd64-race
2021-10-26T21:32:57-69cdffd-86f6bf1/windows-amd64-race
2021-10-26T21:17:38-69cdffd-091db63/windows-amd64-race
2021-10-26T20:41:32-69cdffd-3a0cd11/windows-amd64-race
2021-10-26T20:12:32-69cdffd-f8779b9/windows-amd64-race
2021-10-26T20:08:41-69cdffd-b54bdd2/windows-amd64-race
2021-10-26T19:04:53-69cdffd-1dc77a3/windows-amd64-race
2021-10-26T17:10:45-69cdffd-76cef81/windows-amd64-race
2021-10-26T15:20:53-69cdffd-1b2362b/windows-amd64-race
2021-10-26T14:24:17-69cdffd-283d8a3/windows-amd64-race
2021-10-26T14:05:47-69cdffd-a2b8c18/windows-amd64-race
2021-10-26T11:58:05-69cdffd-1e2820a/windows-amd64-race
2021-10-26T05:05:24-69cdffd-23fdd7f/windows-amd64-race
2021-10-26T01:22:47-69cdffd-adfb85b/windows-amd64-race
2021-10-26T01:07:41-69cdffd-41f7407/windows-amd64-race
2021-10-26T00:38:52-69cdffd-0ec1b62/windows-amd64-race
2021-10-25T23:28:03-69cdffd-e9eb66d/windows-amd64-race
2021-10-25T22:17:34-69cdffd-fd2f4b5/windows-amd64-race
2021-10-25T21:51:20-69cdffd-85b3b4e/windows-amd64-race
2021-10-25T21:16:46-69cdffd-11b64b4/windows-amd64-race
2021-10-25T21:03:33-69cdffd-60c3069/windows-amd64-race
2021-10-25T20:41:00-69cdffd-f92c8f0/windows-amd64-race
2021-10-25T20:12:05-69cdffd-c580180/windows-amd64-race
2021-10-25T20:12:05-69cdffd-2ac3bdf/windows-amd64-race
2021-10-25T20:12:05-69cdffd-252324e/windows-amd64-race
2021-10-25T20:08:25-711f33c-252324e/windows-amd64-race
2021-10-25T18:59:26-711f33c-8c94aa4/windows-amd64-race
2021-10-25T18:46:45-711f33c-f47335e/windows-amd64-race
2021-10-25T17:46:41-711f33c-9012996/windows-amd64-race
2021-10-25T17:29:14-711f33c-95372ef/windows-amd64-race
2021-10-25T17:18:40-711f33c-bc0eb57/windows-amd64-race
2021-10-25T17:09:57-711f33c-70ffd85/windows-amd64-race
2021-10-25T17:02:16-711f33c-52b10ab/windows-amd64-race
2021-10-25T16:07:11-711f33c-c6e82e5/windows-amd64-race
2021-10-25T15:43:33-711f33c-2c66cab/windows-amd64-race
2021-10-25T15:31:40-711f33c-89cc528/windows-amd64-race
2021-10-25T14:50:31-711f33c-1ed060c/windows-amd64-race
2021-10-25T12:07:15-711f33c-fcd2d9c/windows-amd64-race
2021-10-25T11:29:17-711f33c-c580180/windows-amd64-race
2021-10-25T11:29:17-711f33c-7b55457/windows-amd64-race
2021-10-25T11:29:17-711f33c-2ac3bdf/windows-amd64-race
2021-10-25T03:00:02-d6a326f-7b55457/windows-amd64-race
2021-10-23T20:23:35-d6a326f-8dbf3e9/windows-amd64-race
2021-10-23T16:18:19-d6a326f-16318df/windows-amd64-race
2021-10-23T16:17:58-d6a326f-3cd28ba/windows-amd64-race
2021-10-23T12:44:47-d6a326f-b0f7eb6/windows-amd64-race
2021-10-23T08:55:30-d6a326f-c580180/windows-amd64-race
2021-10-23T08:55:30-d6a326f-85d2751/windows-amd64-race
2021-10-23T08:55:30-d6a326f-2ac3bdf/windows-amd64-race

@bcmills bcmills added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 29, 2021
@gopherbot gopherbot added this to the Unreleased milestone Oct 29, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Oct 29, 2021

This test is new as of CL 355495 (CC @mou-hao, @alexbrainman, @odeke-em)

As far as I can tell this is a bug in the test, but it is a release blocker for Go 1.18 via #11811.
(This looks like a good use-case for the new unsafe.Slice!)

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Oct 29, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.18 Oct 29, 2021
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 29, 2021
@mou-hao
Copy link

mou-hao commented Oct 29, 2021

I can fix that.

@cuonglm
Copy link
Member

cuonglm commented Oct 29, 2021

(This looks like a good use-case for the new unsafe.Slice!)

Though it's better to migrate to unsafe.Slice, but I don't think using unsafe.Slice will help in this case. unsafe.Slice only checks for overflow, while the problem here is the underlying array straddle multiple heap objects.

The problem code:

copy((*[1 << 29]uint16)(unsafe.Pointer(&typedBufferPtr.FileName[0]))[:], newNameUTF16)

We need to change it to [:n:n] (where n is len(newNameUTF16)) instead of [:], so the compiler can recognize the pattern and make an exception.

@gopherbot
Copy link

Change https://golang.org/cl/359496 mentions this issue: windows: fix test causing checkptr failure

@alexbrainman
Copy link
Member

We need to change it to [:n:n] (where n is len(newNameUTF16)) instead of [:], so the compiler can recognize the pattern and make an exception.

Indeed. My fault for forgetting it.

Alex

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

5 participants