Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: Table of contents in the language specification missing #49204

Closed
pcostanza opened this issue Oct 28, 2021 · 7 comments
Closed

x/website: Table of contents in the language specification missing #49204

pcostanza opened this issue Oct 28, 2021 · 7 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@pcostanza
Copy link

Since recently, I don't see the table of contents for the language specification at https://golang.org/ref/spec anymore. This is for Safari 15 on macOS. (I see this in Catalina, Big Sur, and Monterey.) On Chrome, the table of contents shows up fine.

It would be great if this could be fixed.

@gopherbot gopherbot added this to the Unreleased milestone Oct 28, 2021
@robpike
Copy link
Contributor

robpike commented Oct 28, 2021

Safari 15.0 shows it fine for me on my iMac running 11.6.

@pcostanza
Copy link
Author

My apologies, I should have checked more carefully. I'm certain I have seen this on Big Sur before, but I cannot verify this anymore. However, I don't see this problem anymore on Monterey, so maybe I'm wrong. But I have also verified this on Catalina just now, and there the problem still exists, I don't see a table of contents there.

@seankhliao
Copy link
Member

The table of contents is generated client side with js, are there any errors when it doesn't render?

@seankhliao seankhliao added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Oct 28, 2021
@pcostanza
Copy link
Author

I see the following messages in the JavaScript console:

[Info] Content blocker prevented frame displaying https://golang.org/ref/spec from loading a resource from https://ssl.google-analytics.com/ga.js (spec, line 6944)
[Error] TypeError: null is not an object (evaluating 'menuButtonEl.addEventListener')
(anonymous function) (godocs.js:18)
Global Code (godocs.js:381)

@seankhliao
Copy link
Member

It targets this line, which certainly appears to exist https://github.com/golang/website/blob/master/_content/site.tmpl#L45 (and works everywhere else). Given that you said it was no longer reproducible on your original machine, could it just be safari's aggressive local caching? (the class name changed a month ago)

@pcostanza
Copy link
Author

I have checked on Catalina again, and emptied caches through the hidden Develop menu in Safari, and now the table of contents indeed show up. I wasn't aware that Safari is so aggressive at caching, I always thought that a reload should do the trick. Thanks a lot for the help, very much appreciated!!!

@seankhliao
Copy link
Member

Closing as this appears to be a browser issue

@golang golang locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

4 participants