Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go list all breaks in //go:build-only repos [1.17 backport] #49199

Closed
gopherbot opened this issue Oct 28, 2021 · 3 comments
Closed

cmd/go: go list all breaks in //go:build-only repos [1.17 backport] #49199

gopherbot opened this issue Oct 28, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.17.3

Comments

@gopherbot
Copy link

@rsc requested issue #49198 to be considered for backport to the next 1.17 minor release.

@gopherbot please backport 1.17
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 28, 2021
@gopherbot gopherbot mentioned this issue Oct 28, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.3 milestone Oct 28, 2021
@rsc
Copy link
Contributor

rsc commented Oct 28, 2021

I misunderstood what gopherbot was telling me in #49198 and submitted the change as f6f024f without CherryPickApproved.

I will leave this issue open in case there is other process that you need to do that I've accidentally jumped over. Apologies.

@dmitshur dmitshur added the GoCommand cmd/go label Oct 29, 2021
@dmitshur
Copy link
Contributor

For cmd/go backports, @bcmills or @matloob can make backport decisions. I expect they're okay with it, so I'll update the status of this to reflect that it's already fixed on release-branch.go1.17 and will be included in the upcoming Go 1.17.3 release. (If need to reverse course, it's possible to revert that CL before the release.)

Closed by merging f6f024f to release-branch.go1.17.

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Oct 29, 2021
@dmitshur dmitshur removed the CherryPickCandidate Used during the release process for point releases label Oct 29, 2021
@bcmills
Copy link
Contributor

bcmills commented Oct 29, 2021

I reviewed and approved the CL, and I am indeed ok with the backport as well. 👍

@golang golang locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.17.3
Development

No branches or pull requests
4 participants
@rsc @dmitshur @bcmills @gopherbot