New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: revise build stamp keys for Go 1.18 #49168
Comments
To clarify: We always prepend the VCS name before |
This is mostly done in CL 358539, but it needs a test-fix before it can be merged. |
The beta is getting close and this is currently marked as blocking the beta. Any news here? |
I just ran this against gotip and didn't see the VCS stuff: info, ok := debug.ReadBuildInfo()
if !ok {
return
}
fmt.Println(info.Settings)
Is that still pending a CL? |
This specific issue is fixed by CL 358539. @carlmjohnson, if you are missing VCS stamps when you expect them, please open a new issue with details and/or steps to reproduce. (I suspect that what you're seeing may have something to do with module/repo boundaries..?) |
Change https://golang.org/cl/369743 mentions this issue: |
CL 358539 revised the build-stamp format, and updated the git and hg tests to match. However, the fossil and bzr tests were missed, and were not caught on the builders due to the fact that none of the builder images have the necessary VCS tools installed. Updates #48802 Updates #49168 Change-Id: I6b9fd0e19b81cb539864c94ab0860f74e7be6748 Reviewed-on: https://go-review.googlesource.com/c/go/+/369743 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
Change https://golang.org/cl/378575 mentions this issue: |
This test was missed in CL 358539, presumably because the 'longtest' builders lack a 'gpg' executable. Updates #49168 Fixes #50675 Change-Id: Ie3bfc761a5e4304531119625742f3def9df8af3f Reviewed-on: https://go-review.googlesource.com/c/go/+/378575 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
This test was missed in CL 358539, presumably because the 'longtest' builders lack a 'gpg' executable. Updates golang#49168 Fixes golang#50675 Change-Id: Ie3bfc761a5e4304531119625742f3def9df8af3f Reviewed-on: https://go-review.googlesource.com/c/go/+/378575 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
In #37475 (comment), @mpx notes that the keys used to record build stamp information are a bit inconsistent: we currently use
gitrevision
,hgrevision
, etc. for each vcs, anduncommitted
for all VCSs.I discussed with @rsc and @matloob, and we are planning to revise these setting-names both to make the VCS settings a bit more uniform and to more clearly distinguish between flags and other metadata. (@rsc may do this as a further patch-set on CL 358539.)
The text was updated successfully, but these errors were encountered: