Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/moddeps: TestAllDependencies fails due to bundle not working #49159

Closed
dmitshur opened this issue Oct 26, 2021 · 2 comments
Closed

cmd/internal/moddeps: TestAllDependencies fails due to bundle not working #49159

dmitshur opened this issue Oct 26, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.18

Comments

@dmitshur
Copy link
Contributor

As of CL 357049, moddeps.TestAllDependencies fails in non-short mode (as detected on the linux-amd64-longtest builder, see log) with:

--- FAIL: TestAllDependencies (9.11s)
    --- FAIL: TestAllDependencies/std(thorough) (4.62s)
        moddeps_test.go:208: > /workdir/tmp/TestAllDependencies2938390985/002/bin/go generate -run=^//go:generate bundle  std
        moddeps_test.go:208: command failed: exit status 1
            bundle: internal error: package "strings" without types was imported from "golang.org/x/net/http2"
            net/http/http.go:5: running "bundle": exit status 1
FAIL
FAIL	cmd/internal/moddeps	9.108s

TestAllDependencies builds and runs bundle, which uses golang.org/x/tools/go/packages to load packages, but starts to run into an internal error after that change.

Perhaps the x/tools version required in src/cmd/go.mod needs to be updated to include CL 358034, or maybe there's more to this.
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Oct 26, 2021
@dmitshur dmitshur added this to the Go1.18 milestone Oct 26, 2021
@dmitshur dmitshur changed the title go/types, cmd/internal/moddeps, x/tools/cmd/bundle: cmd/internal/moddeps: TestAllDependencies fails due to bundle not working Oct 26, 2021
@dmitshur
Copy link
Contributor Author

Perhaps the x/tools version required in src/cmd/go.mod needs to be updated to include CL 358034,

That seems to do the trick. Will send a CL.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 26, 2021
@dmitshur dmitshur self-assigned this Oct 26, 2021
@gopherbot
Copy link

Change https://golang.org/cl/358620 mentions this issue: all: update vendored golang.org/x/tools

@findleyr findleyr mentioned this issue Oct 26, 2021
Closed
@thepudds thepudds mentioned this issue Dec 12, 2021
Closed
@thepudds thepudds mentioned this issue Jan 3, 2022
Closed
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot