Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: README.md has obsolete installation instructions #49114

Closed
jrynd opened this issue Oct 22, 2021 · 2 comments
Closed

x/tools/gopls: README.md has obsolete installation instructions #49114

jrynd opened this issue Oct 22, 2021 · 2 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.7.4

Comments

@jrynd
Copy link

jrynd commented Oct 22, 2021

What version of Go are you using (go version)?

N/A

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

N/A

What did you do?

Viewed README.md file at https://pkg.go.dev/golang.org/x/tools/gopls#section-readme and https://cs.opensource.google/go/x/tools/+/master:gopls/

What did you expect to see?

Instructions using go install or a suggestion to install all of gotools

What did you see instead?

Instructions to install gopls using go get, which doesn't work
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Oct 22, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/358074 mentions this issue: fix: use go installinstead ofgo get``

@seankhliao seankhliao changed the title /x/tools/gopls/README.md has obsolete installation instructions x/tools/gopls: README.md has obsolete installation instructions Oct 24, 2021
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Oct 24, 2021
@gopherbot gopherbot added this to the Unreleased milestone Oct 24, 2021
@seankhliao seankhliao added Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done. labels Oct 24, 2021
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.7.4 Dec 15, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/375774 mentions this issue: gopls: remove obsoleted text from README

gopherbot pushed a commit to golang/tools that referenced this issue Jan 6, 2022
@kolyshkin @findleyr
gopls: remove obsoleted text from README
d4d4325 
CL 358074 changed "go get" to "go install", but forgot to remove the
sentence telling to not use "-u" flag.

As "go install" does not support "-u", the leftover sentence is both
useless and misleading. Remove it.

Updates golang/go#49114

Change-Id: Iec584ae1ea5eb50eb203af48da46bb2ca9e30fc8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/375774
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Nooras Saba‎ <saba@golang.org>
@golang golang locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.7.4
Development

No branches or pull requests
4 participants
@jrynd @gopherbot @seankhliao @findleyr