Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: -buildmode=pie -linkshared panic at runtime [1.17 backport] #49086

Closed
gopherbot opened this issue Oct 20, 2021 · 5 comments
Closed

cmd/link: -buildmode=pie -linkshared panic at runtime [1.17 backport] #49086

gopherbot opened this issue Oct 20, 2021 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.3

Comments

@gopherbot
Copy link

@zhouguangyuan0718 requested issue #47873 to be considered for backport to the next 1.17 minor release.

@gopherbot please consider this for backport to 1.17, maybe we need fix it for 1.17.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 20, 2021
@gopherbot gopherbot mentioned this issue Oct 20, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.3 milestone Oct 20, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/357231 mentions this issue: cmd/link: disable weak reference in itab if build with "-linkshared"

@zhouguangyuan0718 zhouguangyuan0718 mentioned this issue Oct 20, 2021
Closed
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 20, 2021
@dmitshur
Copy link
Contributor

The backport policy requires both supported releases, Go 1.17 and 1.16 at this time, to be supported equally (see https://golang.org/issue/34536#issuecomment-572188389). So to proceed here we need to check if this bug is also present in 1.16, or if it was a regression introduced in Go 1.17.

@zhouguangyuan0718 Do you know if the problem also affects Go 1.16?

@dmitshur dmitshur added CherryPickCandidate Used during the release process for point releases and removed CherryPickApproved Used during the release process for point releases labels Oct 28, 2021
@zhouguangyuan0718
Copy link
Contributor

zhouguangyuan0718 commented Oct 28, 2021 •
edited

The backport policy requires both supported releases, Go 1.17 and 1.16 at this time, to be supported equally (see https://golang.org/issue/34536#issuecomment-572188389). So to proceed here we need to check if this bug is also present in 1.16, or if it was a regression introduced in Go 1.17.

@zhouguangyuan0718 Do you know if the problem also affects Go 1.16?

This bug is present after https://go-review.googlesource.com/c/go/+/268479 summited.
It doesn't affect Go 1.16.

More detailed analysis is here: #47873 (comment).
@dmitshur

@dmitshur
Copy link
Contributor

Thanks for pointing that out. We can proceed with the backport CL, as only 1.17 needs the fix then.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 28, 2021
gopherbot pushed a commit that referenced this issue Oct 28, 2021
@zhouguangyuan0718 @dmitshur
[release-branch.go1.17] cmd/link: disable weak reference in itab if b…
91aa2f1 
…uild with "-linkshared"

When build with "-linkshared", we can't tell if the interface method will be used or not. It can be used in shared library.
This CL backport this fix to 1.17.

Fixes #49086

Change-Id: Iba12812f199b7679cf2fd41a304268d6d6dd03c6
Reviewed-on: https://go-review.googlesource.com/c/go/+/350189
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
(cherry picked from commit f687831)
Reviewed-on: https://go-review.googlesource.com/c/go/+/357231
Trust: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Author

Closed by merging 91aa2f1 to release-branch.go1.17.

@golang golang locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.3
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @zhouguangyuan0718