Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: completion of outstanding issues for generics [freeze exception] #49073

Closed
griesemer opened this issue Oct 19, 2021 · 2 comments
Closed

cmd/compile: completion of outstanding issues for generics [freeze exception] #49073

griesemer opened this issue Oct 19, 2021 · 2 comments
Labels
FrozenDueToAge generics Issue is related to generics NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@griesemer
Copy link
Contributor

There is still quite a bit of work to do on the type checker side (cmd/compile/internal/types2) and possibly the compiler back-end side related to the generics release. A freeze scheduled for Nov 1. 2021 will require us to drop some essential work that needs to be done for generics.

I like to request a freeze exception of two weeks for generics-related work in the compiler, for a freeze on Monday Nov. 15, 2021.

This should include work on the type-checkers (incl. import/export data readers/writers), and possibly the compiler back-end. Please note that we are maintaining two type-checkers in lock-step, cmd/compile/internal/types2 and go/types. Type-checking work may happen in any of those and then is ported essentially 1:1 (but for adjustments due to different AST representations and error handling).

cc: @heschi @toothrot
@griesemer griesemer added the generics Issue is related to generics label Oct 19, 2021
@griesemer griesemer added this to the Go1.18 milestone Oct 19, 2021
@cherrymui cherrymui added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 19, 2021
@heschi
Copy link
Contributor

heschi commented Oct 19, 2021

cc @golang/release

@dmitshur
Copy link
Contributor

dmitshur commented Oct 20, 2021 •
edited

Thank you for letting us know. We have discussed this on the team and agreed that this exception is okay to make for 1.18, especially since this is a part of overall generics work that is in scope of 1.18.

Freeze exception approved.

(I'll close this since I understand the mentioned work is already tracked in other issues; otherwise, feel free to keep this open if it's helpful.)

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Oct 20, 2021
@bradfitz bradfitz mentioned this issue Nov 3, 2021
Closed
@golang golang locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge generics Issue is related to generics NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
5 participants
@dmitshur @griesemer @gopherbot @cherrymui @heschi