Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add longtest builder for darwin/arm64 #49055

Open
cuonglm opened this issue Oct 19, 2021 · 4 comments
Open

x/build: add longtest builder for darwin/arm64 #49055

cuonglm opened this issue Oct 19, 2021 · 4 comments
Labels
arch-arm64 Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. new-builder OS-Darwin
Milestone
Unreleased

Comments

@cuonglm
Copy link
Member

cuonglm commented Oct 19, 2021

See for example #49032, which I think is not caught due to missing longtest builder for darwin/arm64.

cc @golang/release @cherrymui
@cuonglm cuonglm added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 19, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 19, 2021
@gopherbot gopherbot added this to the Unreleased milestone Oct 19, 2021
@ALTree
Copy link
Member

ALTree commented Oct 19, 2021

Related (for darwin/amd64): #35678.

@dmitshur dmitshur mentioned this issue Nov 16, 2021
Closed
@bcmills bcmills mentioned this issue Nov 17, 2022
Closed
@dmitshur dmitshur mentioned this issue Dec 21, 2022
Open
@gopherbot
Copy link

Change https://go.dev/cl/474137 mentions this issue: cmd/go: don't run slow tests on non-longtest builders

gopherbot pushed a commit that referenced this issue Mar 7, 2023
@gopherbot
cmd/go: avoid running slow tests on non-longtest builders
9f532dd 
Also annotate calls to tooSlow with specific reasons.

This will somewhat reduce test coverage on the 'darwin' builders until
we have darwin 'longtest' builders (#35678,#49055), but still seems
worthwhile to avoid alert fatigue from tests that really shouldn't be
running in the short configurations.

Fixes #58918.
Fixes #58919.

Change-Id: I0000f0084b262beeec3eca3e9b8a45d61fab4313
Reviewed-on: https://go-review.googlesource.com/c/go/+/474137
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/474580 mentions this issue: [release-branch.go1.20] cmd/go: avoid running slow tests on non-longtest builders

@gopherbot
Copy link

Change https://go.dev/cl/474581 mentions this issue: [release-branch.go1.19] cmd/go: avoid running slow tests on non-longtest builders

gopherbot pushed a commit that referenced this issue Mar 9, 2023
@cagedmantis
[release-branch.go1.19] cmd/go: avoid running slow tests on non-longt…
fbf4c04 
…est builders

Also annotate calls to tooSlow with specific reasons.

This will somewhat reduce test coverage on the 'darwin' builders until
we have darwin 'longtest' builders (#35678,#49055), but still seems
worthwhile to avoid alert fatigue from tests that really shouldn't be
running in the short configurations.

Updates #58918.
Updates #58919.
Fixes #58937.

Change-Id: I0000f0084b262beeec3eca3e9b8a45d61fab4313
Reviewed-on: https://go-review.googlesource.com/c/go/+/474137
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9f532dd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/474581
gopherbot pushed a commit that referenced this issue Mar 9, 2023
@cagedmantis
[release-branch.go1.20] cmd/go: avoid running slow tests on non-longt…
b852f39 
…est builders

Also annotate calls to tooSlow with specific reasons.

This will somewhat reduce test coverage on the 'darwin' builders until
we have darwin 'longtest' builders (#35678,#49055), but still seems
worthwhile to avoid alert fatigue from tests that really shouldn't be
running in the short configurations.

Updates #58918.
Updates #58919.
Fixes #58938.

Change-Id: I0000f0084b262beeec3eca3e9b8a45d61fab4313
Reviewed-on: https://go-review.googlesource.com/c/go/+/474137
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9f532dd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/474580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-arm64 Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. new-builder OS-Darwin
Projects
Go Release
Status: Planned
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dmitshur @ALTree @cuonglm @bcmills @gopherbot