Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: failures in TestTransportRoundtripCloseOnWriteError with "expected closed" #48995

Closed
bcmills opened this issue Oct 14, 2021 · 2 comments
Closed

x/net/http2: failures in TestTransportRoundtripCloseOnWriteError with "expected closed" #48995

bcmills opened this issue Oct 14, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 14, 2021

greplogs --dashboard -md -l -e '(?m)FAIL: TestTransportRoundtripCloseOnWriteError.*\n.*expected closed'

2021-10-14T19:24:35-2b766c0-4cbc0a5/android-386-emu
2021-10-14T18:44:37-2b766c0-a37bebc/android-386-emu
2021-10-14T17:25:44-2b766c0-c580180/android-amd64-emu
2021-10-13T15:36:59-ee2e9a0-f687831/freebsd-amd64-race
2021-10-13T15:36:59-ee2e9a0-c580180/android-386-emu
2021-10-12T22:02:39-caeb26a-732f6fa/dragonfly-amd64
2021-10-11T12:53:11-3b03d30-34f7b1f/freebsd-amd64-race
2021-10-09T17:34:04-3b03d30-ba2c9fe/android-386-emu
2021-10-08T14:08:12-59d4e92-5b9206f/android-amd64-emu
2021-10-05T15:47:57-d4b1ae0-017ffcd/linux-arm-aws
2021-10-05T14:12:44-d4b1ae0-7983830/android-386-emu
2021-10-05T01:30:56-d4b1ae0-123393a/android-386-emu
2021-10-04T22:08:53-69340ce-7ee4c16/android-amd64-emu
2021-10-04T22:05:34-69340ce-d9952ff/android-386-emu
2021-10-04T20:57:50-b30845b-e8a85e9/android-386-emu
2021-10-04T20:20:20-b30845b-2dc91a2/android-amd64-emu

CC @neild @bradfitz
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Oct 14, 2021
@bcmills bcmills added this to the Go1.18 milestone Oct 14, 2021
@gopherbot
Copy link

Change https://golang.org/cl/356029 mentions this issue: http2: on write errors, close ClientConn before returning from RoundTrip

@gopherbot
Copy link

Change https://golang.org/cl/356030 mentions this issue: http2: don't abort half-closed streams on server connection close

gopherbot pushed a commit to golang/net that referenced this issue Oct 15, 2021
@neild
http2: don't abort half-closed streams on server connection close
db2dff3 
If the server sends an END_STREAM for a stream and then closes the
connection, allow the stream to complete normally.

Fixes golang/go#48995

Change-Id: Ia876e6e6e7eb4a0563db74c931c03a44620ece08
Reviewed-on: https://go-review.googlesource.com/c/net/+/356030
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@neild
http2: on write errors, close ClientConn before returning from RoundTrip
e3debd4 
Deflakes TestTransportRoundtripCloseOnWriteError.

Fixes golang/go#48995.

Change-Id: I4384d9091d55307d15fbd44b1b8137dcc8939c86
Reviewed-on: https://go-review.googlesource.com/c/net/+/356029
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@neild
http2: don't abort half-closed streams on server connection close
b4d53e0 
If the server sends an END_STREAM for a stream and then closes the
connection, allow the stream to complete normally.

Fixes golang/go#48995

Change-Id: Ia876e6e6e7eb4a0563db74c931c03a44620ece08
Reviewed-on: https://go-review.googlesource.com/c/net/+/356030
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@bcmills @gopherbot