Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug/macho: invalid dynamic symbol table command can cause panic [1.17 backport] #48992

Closed
gopherbot opened this issue Oct 14, 2021 · 4 comments
Closed

debug/macho: invalid dynamic symbol table command can cause panic [1.17 backport] #48992

gopherbot opened this issue Oct 14, 2021 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Security
Milestone
Go1.17.3

Comments

@gopherbot
Copy link

@rolandshoemaker requested issue #48990 to be considered for backport to the next 1.17 minor release.

@gopherbot please open backport issues
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 14, 2021
@gopherbot gopherbot mentioned this issue Oct 14, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.3 milestone Oct 14, 2021
@cherrymui
Copy link
Member

Approved for backport. Thanks.

@cherrymui cherrymui added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 20, 2021
@dmitshur
Copy link
Contributor

@rolandshoemaker Can you please prepare two backport CL (here, and for #48991) following https://golang.org/wiki/MinorReleases#making-cherry-pick-cls? Thanks.

@gopherbot
Copy link
Author

Change https://golang.org/cl/359455 mentions this issue: [release-branch.go1.17] debug/macho: fail on invalid dynamic symbol table command

gopherbot pushed a commit that referenced this issue Oct 29, 2021
@rolandshoemaker @dmitshur
[release-branch.go1.17] debug/macho: fail on invalid dynamic symbol t…
4a84298 
…able command

Fail out when loading a file that contains a dynamic symbol table
command that indicates a larger number of symbols than exist in the
loaded symbol table.

Thanks to Burak Çarıkçı - Yunus Yıldırım (CT-Zer0 Crypttech) for
reporting this issue.

Updates #48990
Fixes #48992
Fixes CVE-2021-41771

Change-Id: Ic3d6e6529241afcc959544b326b21b663262bad5
Reviewed-on: https://go-review.googlesource.com/c/go/+/355990
Reviewed-by: Julie Qiu <julie@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Katie Hockman <katie@golang.org>
(cherry picked from commit 61536ec)
Reviewed-on: https://go-review.googlesource.com/c/go/+/359455
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Author

Closed by merging 4a84298 to release-branch.go1.17.

@fgma fgma mentioned this issue Dec 29, 2021
Merged
3 tasks
@golang golang locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Security
Projects
None yet
Milestone
Go1.17.3
Development

No branches or pull requests
4 participants
@dmitshur @rolandshoemaker @gopherbot @cherrymui