Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add e2e image snapshots for dark mode #48982

Open
jamalc opened this issue Oct 14, 2021 · 0 comments
Open

x/pkgsite: add e2e image snapshots for dark mode #48982

jamalc opened this issue Oct 14, 2021 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@jamalc
Copy link

jamalc commented Oct 14, 2021

We should consider adding snapshot tests for dark mode on a subset of pages from the e2e test suite. Full coverage is unlikely to be necessary because we have restricted color usage on pkg.go.dev to CSS variables for color intent.
@jamalc jamalc added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Oct 14, 2021
@jamalc jamalc added this to the pkgsite/unplanned milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
1 participant
@jamalc