-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/windows: add NtSetInformationFile #48933
Labels
Milestone
Comments
mou-hao
added a commit
to mou-hao/bb-storage
that referenced
this issue
Oct 13, 2021
local_directory_windows.go makes use of consts and syscalls not present in x/sys/windows. I have moved them out into a separate pkg and plan to create a PR to x/sys/windows to add them there (where they should be). See: - https://go-review.googlesource.com/c/sys/+/355350 - golang/go#48933
mou-hao
added a commit
to mou-hao/bb-storage
that referenced
this issue
Oct 13, 2021
local_directory_windows.go makes use of consts and syscalls not present in x/sys/windows. I have moved them out into a separate pkg and plan to create a PR to x/sys/windows to add them there (where they should be). See: - https://go-review.googlesource.com/c/sys/+/355350 - golang/go#48933
Thanks. It's not necessary to make a proposal to add an existing Windows function to x/sys/windows. You can just send the CL. |
Change https://golang.org/cl/355495 mentions this issue: |
EdSchouten
pushed a commit
to buildbarn/bb-storage
that referenced
this issue
Oct 13, 2021
* local_directory_windows passing all tests windows handle based impl to mimic as much as possible the behavior of local_directory_unix * move extension to x/sys/windows to separate pkg local_directory_windows.go makes use of consts and syscalls not present in x/sys/windows. I have moved them out into a separate pkg and plan to create a PR to x/sys/windows to add them there (where they should be). See: - https://go-review.googlesource.com/c/sys/+/355350 - golang/go#48933
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Hi! When I was trying to implement a windows file handle based filesystem abstraction, I find
NtSetInformationFile
to be very useful used in conjunction withNtCreateFile
.NtSetInformationFile
supports file information classes not supported bySetFileInformationByHandle
, for exampleFileDispositionInformationEx
where you can use theFILE_DISPOSITION_POSIX_SEMANTICS
flag to get posix stype delete.The Microsoft doc for
NtSetInformationFile
can be found here: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/nf-ntifs-ntsetinformationfileThis should be a small change, as we already load
ntdll.dll
forNtCreateFile
and more. I have already implemented it in another project. Use cases can be found here.Thanks.
The text was updated successfully, but these errors were encountered: