Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestServeHTTP10Close failure with "body not closed" #48927

Open
bcmills opened this issue Oct 12, 2021 · 0 comments
Open

net/http: TestServeHTTP10Close failure with "body not closed" #48927

bcmills opened this issue Oct 12, 2021 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 12, 2021 

--- FAIL: TestServeHTTP10Close (12.66s)
    serve_test.go:1096: body not closed after 5s
FAIL
FAIL	net/http	18.149s

greplogs --dashboard -md -l -e '(?ms)FAIL: TestServeHTTP10Close.*body not closed after' --since=2020-10-20

2021-10-12T11:00:47-9c1dbdf/solaris-amd64-oraclerel

It isn't obvious to me whether this was a test flake due to a slow builder or something more serious. But it also isn't obvious to me why the test has a 5-second timeout — the hard-coded timeout appears to date to CL 4235056, and neither the code review thread nor the code indicates the logic behind it.

CC @neild
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 12, 2021
@bcmills bcmills added this to the Backlog milestone Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@bcmills