go/build: should package be aware of GOBIN? #4891
Labels
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
Currently all handling of the GOBIN environment variable is in cmd/go. Another (perhaps better) approach would be to add a GOBIN field to go/build's Context, and have the handling done there. If the GOBIN field is empty it should be ignored, preserving backward compatibility with 1.0. Although if defaultContext pulls the GOBIN from the environment, this potentially breaks backward compat, although it's arguably a bug fix. In summary, I'm inclined to support adding a GOBIN field to go/build's Context, and removing the GOBIN handling from cmd/go. What say Russ? Labels changed: added priority-later, removed priority-triage. Status changed to Accepted. |
I have made some changes (attached diff) that yield the expected results for go/build.. Added the GOBIN field in go/build's Context. I also tried to removing the GOBIN handling from cmd/go. However, the go tool still checks and applies GOBIN in some situations outside the BinDir field from go/build's Package. So I'm not fully satisfied with this patch, but it might be a good indication and/or be used for backward compatibility tests. Attachments:
|
|
It's been a while and I thought I'd pick this up again. I've made the changes to |
seankhliao
added
the
NeedsInvestigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using build.Import("GOPATH/src/myCmd", "", 0) a *Package is returned that has the field BinDir set to be GOPATH/bin. Package.BinDir is documented as "command install directory". However: cmd/go states "If the GOBIN environment variable is set, commands are installed to the directory it names instead of DIR/bin." (http://golang.org/cmd/go/#hdr-GOPATH_environment_variable) Is it up to pkg/go/build to check for the existence of GOBIN? Or should a user implementation check for GOBIN? Example of a fix: GeertJohan/rerun@b3bf4d7 pkg/go/build source code concerning the *Package BinDir field: http://code.google.com/p/go/source/browse/src/pkg/go/build/build.go#521The text was updated successfully, but these errors were encountered: