Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: drop unused GOPATH subrepo testing path #48875

Closed
prattmic opened this issue Oct 8, 2021 · 2 comments
Closed

x/build/cmd/coordinator: drop unused GOPATH subrepo testing path #48875

prattmic opened this issue Oct 8, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@prattmic
Copy link
Member

prattmic commented Oct 8, 2021

In the coordinator, subrepo testing splits into two paths depending on whether the subrepo is in module mode or not.

I looked through all of our subrepos, and as far as I can tell they all use modules now, so I think this could be cleaned up to only support modules?

cc @golang/release
@prattmic prattmic added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 8, 2021
@prattmic prattmic added this to the Backlog milestone Oct 8, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 8, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Oct 8, 2021

Yes, I think by now it's safe to drop that path.

Issue #30233 was open for a long time to test some x repos in both modes, but we got by without ever implementing it. Given the status of GOPATH mode by now, I understand it has (and can have) sufficient test coverage via cmd/go tests in the main repository (CC @bcmills @jayconrod @matloob), so nothing more is needed for x repos.

@dmitshur dmitshur changed the title x/build/cmd/coordinator: drop GOPATH subrepo testing? x/build/cmd/coordinator: drop unused GOPATH subrepo testing path Oct 8, 2021
@dmitshur dmitshur mentioned this issue Oct 8, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/355089 mentions this issue: cmd/coordinator: drop subrepo GOPATH testing support

@golang golang locked and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@prattmic @dmitshur @gopherbot